Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS files in src/screens/PageNotFound #2524

Closed
AVtheking opened this issue Nov 30, 2024 · 8 comments
Closed

Refactor CSS files in src/screens/PageNotFound #2524

AVtheking opened this issue Nov 30, 2024 · 8 comments
Assignees
Labels
feature request good first issue Good for newcomers no-issue-activity No issue activity refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved

Comments

@AVtheking
Copy link
Contributor

Refactor CSS files in src/screens/PageNotFound

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

Additional information:

  1. The foundational work for this was completed in this PR:
  2. The desired single CSS file is:
    • src/style/app.module.css

The challenge:

The goal is to convert the CSS file in this subdirectory and all the components related to this screen to use this new design pattern. This means that:

  1. All CSS files in this subdirectory and all the CSS files in related components must be merged into the global CSS file using pre-existing CSS.
  2. All CSS files in this subdirectory and all the CSS files in related components must be deleted after the merge.
  3. The remaining relevant files in this subdirectory must only reference the global CSS file.
  4. All the CSS files in the related components of this subdirectory must adhere to the same guidelines.
@github-actions github-actions bot added refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Nov 30, 2024
@mandeepnh5
Copy link
Contributor

can i work on this issue

@mandeepnh5
Copy link
Contributor

I have created the pull request please check it

@mandeepnh5
Copy link
Contributor

@palisadoes can I know what what is the issue in my PR, I am new here so I am not sure

@palisadoes
Copy link
Contributor

This PR needed to be closed.

The source and target PR branches are the same. This means that our reviewers will not be able to checkout the changes and test on their systems using this methodology which will cause a rejection error:

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Please follow these steps:

  1. Create a new branch with a different name in your local repository
    1. Make sure the branch name is named differently from the required target branch in the PR
    2. Use the git checkout -b command to do this.
  2. Resubmit your PR

@mandeepnh5
Copy link
Contributor

@palisadoes Ok thanks for guidance I have created PR again please check

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@palisadoes
Copy link
Contributor

We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:

  1. We start looking for people to review PRs when you submit them.
  2. We often contact them and link to the PR. If the PR is closed the whole effort is wasted.
  3. The historical thread of reviewer comments is broken when the work is spread across multiple PRs. The quality of our code is affected negatively.

Please be considerate of our volunteers' limited time and our desire to improve our code base.

This policy is stated as a pinned post in all our Talawa repositories. Our YouTube videos explain why this practice is not acceptable to our Community.

In most cases you don’t have to close the PR to trigger the GitHub workflow to run again. Making a new commit and pushing it to your GitHub account will normally be sufficient.

Unfortunately, if this continues we will have to close the offending PR and unassign you from the issue.

image

@mandeepnh5
Copy link
Contributor

mandeepnh5 commented Dec 21, 2024

Thank you soo much for guidance looking forward to contribute more
Sorry for the multiple pr I was new to this so I didn't manage properly, this won't happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers no-issue-activity No issue activity refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved
Projects
Status: Done
Development

No branches or pull requests

3 participants