Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS files in src/screens/UserPortal #2527

Closed
AVtheking opened this issue Nov 30, 2024 · 17 comments
Closed

Refactor CSS files in src/screens/UserPortal #2527

AVtheking opened this issue Nov 30, 2024 · 17 comments
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@AVtheking
Copy link
Contributor

Refactor CSS files in src/screens/UserPortal

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

Additional information:

  1. The foundational work for this was completed in this PR:
  2. The desired single CSS file is:
    • src/style/app.module.css

The challenge:

The goal is to convert the CSS file in this subdirectory and all the components related to this screen to use this new design pattern. This means that:

  1. All CSS files in this subdirectory and all the CSS files in related components must be merged into the global CSS file using pre-existing CSS.
  2. All CSS files in this subdirectory and all the CSS files in related components must be deleted after the merge.
  3. The remaining relevant files in this subdirectory must only reference the global CSS file.
  4. All the CSS files in the related components of this subdirectory must adhere to the same guidelines.
@github-actions github-actions bot added refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Nov 30, 2024
@matinshaikh31
Copy link

Can i work on it

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 11, 2024
@Cioppolo14
Copy link
Contributor

Unassigning due to inactivity.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 12, 2024
@alabhyamobar
Copy link

I am Alabhya mobar , i am a frontend developer and i want to work on this issue

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 25, 2024
@palisadoes
Copy link
Contributor

@alabhyamobar

Unassigning due to inactivity and/or no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@gurramkarthiknetha
Copy link
Contributor

If no one is currently working on this issue, I would like to take it on. Please assign it to me.

@palisadoes
Copy link
Contributor

With this issue we are migrating from the previous green based color scheme where the #31bb6b color was used for many elements to one using a color scheme similar to that of Gmail.

This makes the app more usable for people with red/green color blindness

When making your changes, make the effort to use pre-existing colors in the src/style/app.module.css file.

@gurramkarthiknetha
Copy link
Contributor

With this issue we are migrating from the previous green based color scheme where the #31bb6b color was used for many elements to one using a color scheme similar to that of Gmail.

This makes the app more usable for people with red/green color blindness

When making your changes, make the effort to use pre-existing colors in the src/style/app.module.css file.

Ok @palisadoes thank you for your advice

@palisadoes
Copy link
Contributor

Unassigning due to repeatedly not addressing my concerns in the linked PR in good faith.

@gurramkarthiknetha
Copy link
Contributor

Unassigning due to repeatedly not addressing my concerns in the linked PR in good faith.

Apologies for not addressing the concerns in the linked PR effectively. I request reassignment of the issue to make the necessary improvements and resolve it properly.

@gurramkarthiknetha
Copy link
Contributor

Thank you for reassigning the issue. I appreciate your support and will make sure to address all concerns thoroughly.

@palisadoes
Copy link
Contributor

@gurramkarthiknetha

  1. Unassigning.
  2. You seem to be using some sort of automation. The PR is closed and you are still making commits.
  3. Who else would like to work on this?

@gurramkarthiknetha
Copy link
Contributor

gurramkarthiknetha commented Jan 5, 2025

@gurramkarthiknetha

  1. Unassigning.
  2. You seem to be using some sort of automation. The PR is closed and you are still making commits.
  3. Who else would like to work on this?

The pull request (PR) has been closed, but automated commits are still being pushed to it. I’ll be taking over the issue from here. Could you please reassign the issue to me? I will create a new PR to continue the work and address any outstanding tasks.

@gurramkarthiknetha
Copy link
Contributor

Could you please reassign the issue to me? I'll create a new PR to continue the work.

@palisadoes
Copy link
Contributor

Absolutely not.

@palisadoes
Copy link
Contributor

Someone else can give it a try. You had ample warning over multiple days and with numerous dismissed PR reviews by you.

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Talawa Admin - Refactoring Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: Done
Status: Done
Development

No branches or pull requests

7 participants