Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: src/screens/Requests from Jest to Vitest #2569

Closed
VanshikaSabharwal opened this issue Dec 1, 2024 · 3 comments
Closed

Refactor: src/screens/Requests from Jest to Vitest #2569

VanshikaSabharwal opened this issue Dec 1, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application

Comments

@VanshikaSabharwal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This file is currently tested using Jest. As part of our migration to Vitest, we need to refactor this file's test cases to align with Vitest's syntax and features.

Acceptance Criteria

  1. Replace Jest-specific functions and mocks with Vitest equivalents
  2. Ensure all tests in src/screens/Requests pass after migration using npm run test:vitest
  3. Maintain the test coverage for the file as 100% after migration
  4. Upload a video or photo for this specific file coverage is 100% in the PR description

Additional context

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@shivasankaran18
Copy link
Contributor

shivasankaran18 commented Dec 12, 2024

can I work on this..?..Fixed the issue ..Will raise a PR if you could please assign this issue

@bandhan-majumder
Copy link
Contributor

bandhan-majumder commented Dec 12, 2024

Hi @shivasankaran18 . I was about to ask as I fixed it as well. But sure, please raise a PR after getting assigned. Happy contributing.

@shivasankaran18
Copy link
Contributor

shivasankaran18 commented Dec 12, 2024

yeah ok @bandhan-majumder ..happy contributing to you as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application
Projects
Status: Done
Archived in project
Development

No branches or pull requests

5 participants