-
-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: src/utils/useSession.test.tsx
from Jest to Vitest
#2754
Comments
@palisadoes I would like to work on issue #2754 to migrate useSession.test.tsx from Jest to Vitest. I understand this requires:
I've reviewed the base Vitest config PR and documentation. May I be assigned to this task? |
…alisadoesFoundation#2754) - Updated test cases and configurations to align with Vitest framework. Ensured tests pass and maintained/improved coverage.
We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:
Please be considerate of our volunteers' limited time and our desire to improve our code base. This policy is stated as a pinned post in all our Talawa repositories. Our YouTube videos explain why this practice is not acceptable to our Community. In most cases you don’t have to close the PR to trigger the GitHub workflow to run again. Making a new commit and pushing it to your GitHub account will normally be sufficient. Unfortunately, if this continues we will have to close the offending PR and unassign you from the issue. |
Dear Peter Harrison,
I sincerely apologize for closing the pull request without validation from
the reviewer team. The branch had some issues, which I have now resolved,
but I realize this disrupted the workflow and wasted valuable effort.
Moving forward, I’ll ensure all changes comply with our community’s
policies and avoid such actions in the future. Thank you for your
understanding.
Best regards,
Vivek Bisen
…On Sat, Dec 28, 2024 at 8:18 PM Peter Harrison ***@***.***> wrote:
We have a policy of unassigning contributors who close PRs without getting
validation from our reviewer team. This is because:
1. We start looking for people to review PRs when you submit them.
2. We often contact them and link to the PR. If the PR is closed the
whole effort is wasted.
3. The historical thread of reviewer comments is broken when the work
is spread across multiple PRs. The quality of our code is affected
negatively.
Please be considerate of our volunteers' limited time and our desire to
improve our code base.
This policy is stated as a pinned post in all our Talawa repositories. Our
YouTube videos explain why this practice is not acceptable to our Community.
In most cases you don’t have to close the PR to trigger the GitHub
workflow to run again. Making a new commit and pushing it to your GitHub
account will normally be sufficient.
Unfortunately, if this continues we will have to close the offending PR
and unassign you from the issue.
- This can be seen here
image.png (view on web)
<https://github.com/user-attachments/assets/6054c0d5-9b37-4742-bb09-d02d2690d7c6>
- And here too
image.png (view on web)
<https://github.com/user-attachments/assets/24da4c29-e015-4479-b323-14fbedfdda9e>
—
Reply to this email directly, view it on GitHub
<#2754 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A44DZ7FDLJKTJZTIHMGGGHT2H225PAVCNFSM6AAAAABUEJM53GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUGM2DCNZRHA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Is your feature request related to a problem? Please describe.
This file is currently tested using Jest. As part of our migration to Vitest, we need to refactor this file's test cases to align with Vitest's syntax and features.
Acceptance Criteria
.test.*
suffix to a.spec.*
suffixnpm run test:vitest
Additional context
https://github.com/PalisadoesFoundation/talawa-admin/pull/2457/files#diff-9a5a35cf8d7f02b2bba90905714b762560579c4789e9eb4cebb4607980aa3d93
https://vitest.dev/
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: