Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS in src/components/Advertisements/core/AdvertisementEntry #3254

Closed
rahulch07 opened this issue Jan 11, 2025 · 9 comments
Closed
Assignees
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@rahulch07
Copy link
Contributor

Refactor CSS in this file

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

This file contains embedded CSS references that should be completely moved to:

  • src/style/app.module.css

Additional Information:

  1. The foundational work for this was completed in this PR:
  2. The desired single CSS file is:
    • src/style/app.module.css

The Challenge:

The goal is for this file to use the new design pattern. This means that:

  1. All embedded CSS in this file must be merged into the global CSS file using pre-existing CSS.
  2. All embedded CSS in this file must be removed.
@github-actions github-actions bot added refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Jan 11, 2025
@rahulch07
Copy link
Contributor Author

Related PR #2984

@rushichavan21
Copy link

I’d like to take up this issue if it’s available.

@SnowFlowerr
Copy link

@rahulch07 please assign me this issue.

@Cioppolo14
Copy link
Contributor

@rushichavan21 @SnowFlowerr If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance.

@palisadoes
Copy link
Contributor

Unassigning so you can work on the follow up for this:

@palisadoes
Copy link
Contributor

We created an this issue to do basic changes to the CSS colors for consistency

The resulting PR created a comprehensive design system for the entire app. This was unexpected. The approach was a long term goal that became immediately implementable. We had to act promptly.

We have just merged the PR. There will be a follow up PR to adjust some colors as the Figma design has lettering that is sometimes hard to read.

When this is done we'll need your assistance to merge the screens into the develop branch with this issue.

If your screens have not been affected, then you should use the new methodology to refactor them.

This is an extraordinary circumstance. I hope you will appreciate the decision.

1 similar comment
@palisadoes
Copy link
Contributor

We created an this issue to do basic changes to the CSS colors for consistency

The resulting PR created a comprehensive design system for the entire app. This was unexpected. The approach was a long term goal that became immediately implementable. We had to act promptly.

We have just merged the PR. There will be a follow up PR to adjust some colors as the Figma design has lettering that is sometimes hard to read.

When this is done we'll need your assistance to merge the screens into the develop branch with this issue.

If your screens have not been affected, then you should use the new methodology to refactor them.

This is an extraordinary circumstance. I hope you will appreciate the decision.

@hustlernik
Copy link
Contributor

can I work on this?

@hustlernik
Copy link
Contributor

It is already fixed, ig this issue should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: Done
Status: Done
Development

No branches or pull requests

6 participants