Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint to Update and Save Application #112

Closed
Buwujiu opened this issue Dec 18, 2024 · 3 comments
Closed

Endpoint to Update and Save Application #112

Buwujiu opened this issue Dec 18, 2024 · 3 comments
Assignees
Labels

Comments

@Buwujiu
Copy link
Contributor

Buwujiu commented Dec 18, 2024

Descriptions

To support application editing, we need a REST endpoint to allow content update and application saving.

Acceptance Criteria

@Buwujiu
Copy link
Contributor Author

Buwujiu commented Jan 9, 2025

The endpoint was done in ticket #22 (PR #80), refer to edit application in https://daco-api.pcgl-dev.cumulus.genomeinformatics.org/api-docs/#/Applications/post_applications_edit. No more coding required anymore, closing ticket.

@Buwujiu Buwujiu closed this as completed Jan 9, 2025
@joneubank
Copy link
Contributor

Reopening so we can review and confirm some details:

  • Able to receive partial application content object
    • will overwrite properties that are included in the sent data
    • will not change properties that are missing in the sent data
    • to clear a value, send that property as a null value. For string fields, sending an empty string is also acceptable (standard form behaviour).
  • Edit should not validate the application content... this is a work in progress submission, validation can be done on the UI and should be checked when user tries to submit.

@joneubank joneubank reopened this Jan 9, 2025
@Buwujiu
Copy link
Contributor Author

Buwujiu commented Jan 20, 2025

Tested all the use cases in dev, logged 1 feedback. Endpoint works as expected.

@Buwujiu Buwujiu closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants