Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage and My Applications Page Feedback #157

Open
Buwujiu opened this issue Jan 16, 2025 · 0 comments · Fixed by #160
Open

Homepage and My Applications Page Feedback #157

Buwujiu opened this issue Jan 16, 2025 · 0 comments · Fixed by #160
Assignees
@JamesTLopez

Comments

@Buwujiu
Copy link
Contributor

Buwujiu commented Jan 16, 2025 •
edited
Loading

Patrick tested homepage and My Applications page in dev, and reported a few feedback in:
https://docs.google.com/document/d/1fiRfRZARJY3-IvK7k192x-RBWmca9V7To-xszaY0wqg/edit?usp=sharing, please review them and make changes accordingly.
@JamesTLopez JamesTLopez self-assigned this Jan 16, 2025
@JamesTLopez JamesTLopez linked a pull request Jan 20, 2025 that will close this issue
#157: Homepage and My Applications Page Enhancements #160
Merged
6 tasks
JamesTLopez added a commit that referenced this issue Jan 22, 2025
@JamesTLopez
#157: Homepage and My Applications Page Enhancements (#160)
098eff0 
* fix(homepage): reduce max width for hero and content sections

* fix(homepage): increase gap between content items

* fix(footer): reduce text to 12px

* fix(header): add logout button

* fix(footer): align pcgl logo to left on tablet view

* fix(homepage): align content properly

* chore(comments): update copyright

* chore(imports): organize imports

* fix(footer-logo): center logo only on mobile size

* fix(get-started): prevent padding being applied from gutter

* chore(typo): mispelt complianceTextStyle

* feat(footer): responsiv footer updates

- replace useMinWidth hook with breakpoints hook
- create a new footer block
 - this footer block is needed to match desktop and tablet/mobile views
@Buwujiu Buwujiu reopened this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesTLopez JamesTLopez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#157: Homepage and My Applications Page Enhancements Pan-Canadian-Genome-Library/daco
2 participants
@Buwujiu @JamesTLopez