Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request action requires organization name #24

Open
jmezach opened this issue Nov 10, 2023 · 1 comment
Open

Pull request action requires organization name #24

jmezach opened this issue Nov 10, 2023 · 1 comment

Comments

@jmezach
Copy link

jmezach commented Nov 10, 2023

While testing out these actions I ran into an issue with the azure:repo:pr action. It failed with this rather cryptic error message:

[1]2023-11-10T03:19:35.000Z Beginning step Create a Pull Request to Azure Repo
[2]2023-11-10T03:19:35.000Z TypeError: Cannot read properties of null (reading 'value')
[3]    at <anonymous> (/Users/jmezach/Code/rr/Backstage/node_modules/@antoniobergas/scaffolder-backend-module-azure-repositories/node_modules/azure-devops-node-api/VsoClient.js:124:52)
[4]    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

I managed to fix the issue by passing in the organization parameter, so it seems that that is actually required. But this is not described in the README, nor does it state so in the schema. As also mentioned in #23 I think these actions should maybe accept the output of the RepoPicker directly and then build the appropriate URL's internally.

@fosterm-mw
Copy link
Contributor

This can also be changed in the file to be required so that the error is not as cryptic https://github.com/Parfuemerie-Douglas/scaffolder-backend-module-azure-repositories/blob/main/src/actions/run/pullRequestAzureRepo.ts#L37. As for the output of the RepoPicker, are you interested in opening a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants