feat: tweak the CompactStringExt trait so join_compact and concat_compact work better
#418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpact work better * changes the blanket trait impl so iterator types like Map can also have join_compact called with them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412
This is a possibly breaking change.
Previously
CompactStringExtwas (more or less) implemented for any typeCwhere a&CimplementedIntoIterator<Item = &str>. This worked well for when you wanted to joinVecs or slices, but would result in a confusing compile time error when you tried to join an iterator of some type, e.g. when you tried to dovalues.iter().map(|val| val.trim()).join_compact(",").There is a blanket impl for
IntoIteratorfor all types that implementIterator, but our trait bound required some reference of a type to implementIntoIteratorwhich wasn't covered by this blanket impl.