Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salt management efficiency #31

Closed
firaja opened this issue Feb 6, 2021 · 0 comments
Closed

Salt management efficiency #31

firaja opened this issue Feb 6, 2021 · 0 comments
Assignees
@firaja
Labels
good first issue Good for newcomers priority: high type: enhancement
Milestone
1.5.2

Comments

@firaja
Copy link
Member

firaja commented Feb 6, 2021

When using hash(String) the salt is automatically generated as array of bytes, then converted into String and passed to hash(String, String) and in many cases i converted into array of bytes.

This double conversion is useless, even if the drop in performance is minimal.
@firaja firaja added this to the 1.6.0 milestone Feb 6, 2021
@firaja firaja self-assigned this Feb 6, 2021
@firaja firaja modified the milestones: 1.6.0, 1.5.2 Feb 8, 2021
firaja added a commit that referenced this issue Feb 8, 2021
@firaja
#31: salt is converted just once
58f463f
@firaja firaja closed this as completed Feb 8, 2021
@firaja firaja modified the milestones: 1.5.2, 1.6.0 Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@firaja firaja

Labels
good first issue Good for newcomers priority: high type: enhancement
Projects
None yet
Milestone
1.5.2
Development

No branches or pull requests
1 participant
@firaja