Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting previous query text in search bar: empty screen #1075

Closed
jvwong opened this issue Aug 16, 2022 · 4 comments
Closed

Deleting previous query text in search bar: empty screen #1075

jvwong opened this issue Aug 16, 2022 · 4 comments
Labels

Comments

@jvwong
Copy link
Member

jvwong commented Aug 16, 2022

Would expect deleting text of previous query to show default (all).

@jvwong jvwong added the bug label Aug 16, 2022
@maxkfranz
Copy link
Member

maxkfranz commented Aug 16, 2022 via email

@jvwong
Copy link
Member Author

jvwong commented Aug 17, 2022

That’s a good catch. By the way, are we measuring how much the search feature is used?

Not currently. Related is #1053: I realized that I didn't really have enough detail about what we want to capture and how, so maybe we can table this for discussion. It's also important as I rev up the email campaign numbers.

@jvwong
Copy link
Member Author

jvwong commented Aug 31, 2022

Reproducing this error is peculiar.

Type SENP1 then:

  1. Slowly delete each character: Works as expected (list of all docs)
  2. Quickly delete each character: Broken (empty screen)

Untitled

@jvwong
Copy link
Member Author

jvwong commented Aug 31, 2022

Best guess what's happening is that the debounced searches are getting 'queued'. These queued searches can be dequeued following empty search box (after deleting all text), and in doing so, an empty string is used in a debouced query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants