Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use webview or iframe? #1

Open
PerBothner opened this issue Dec 12, 2017 · 0 comments
Open

use webview or iframe? #1

PerBothner opened this issue Dec 12, 2017 · 0 comments

Comments

@PerBothner
Copy link
Owner

Depending on the usingWebview variable, atom-domterm can use either a <webview> or an <iframe> for the embedded terminal emulator. Currently, it works better with <iframe> (usingWebview is false), so that is the default. The main problems with using <webview> are:

  1. Serialization with <webview> isn't working - which causes lots of problems. I don't know why - it could be related to the DomTermView class not extending View. (I haven't figured out how to do that in plain JavaScript.)
  2. The Atom keybindings override DomTerm's handling of key events. Given that a terminal emulator needs to handle most keybindings on its own, this is a problem. The keymaps/domterm.cson file fixes some of the problems, but it would be better for the default to be native. (I can't get native-key-bindings to work.) Using an <frame> handles this by default.

On the other hand, there are some things using <webview> with node integration handles better than <iframe>. I've been fixing various <iframe> problems but it seems to be fighting the system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@PerBothner and others