Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to slp-validate #64

Open
christroutner opened this issue Jul 13, 2020 · 1 comment
Open

Fall back to slp-validate #64

christroutner opened this issue Jul 13, 2020 · 1 comment

Comments

@christroutner
Copy link

christroutner commented Jul 13, 2020

On July 11th, an SLP transaction was broadcast that made all the SLPDBs stall and stop validating transactions. When this happened, the token-liquidity app stopped being able to identify incoming UTXOs as token UTXOs. This sanity check code was triggered, which at least dropping red flags into the logs.

The scope of this task is to expand the this sanity check code. Instead of the current functionality, the following checks should be conducted:

  • slp-parser should be applied to the transaction. If it throws an error, then the UTXO is not an SLP transaction and it can be treated as BCH.
  • If slp-parser does not throw an error, then the UTXO may be a token UTXO. The UTXO should be run through slp-validate to manually validate the DAG and ensure this isn't a token UTXO that SLPDB missed.
@christroutner
Copy link
Author

Another corner case that effects this scenario is when non-PSF SLP tokens are sent to the token-liquidity app. It will be necessary to call the bchjs.SLP.Utils.tokenUtxoDetails() to verify that the token is actually a PSF token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant