Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public static inner classes migration #30

Open
Philzen opened this issue Jun 14, 2024 · 1 comment
Open

public static inner classes migration #30

Philzen opened this issue Jun 14, 2024 · 1 comment
Labels
Feature New feature or request must-have

Comments

@Philzen
Copy link
Owner

Philzen commented Jun 14, 2024 •
edited
Loading

Simply add @Nested annotation to public static inner classes and remove their static keyword.
@Philzen Philzen changed the title Add @Nested annotation to public static inner classes and remove static keyword public static inner classes migration Jun 14, 2024
@Philzen Philzen added Feature New feature or request must-have labels Jun 14, 2024
@Philzen Philzen moved this to Done in TestNG → Jupiter Jun 14, 2024
@Philzen Philzen closed this as completed by moving to Done in TestNG → Jupiter Jun 14, 2024
@Philzen Philzen moved this from Done to In review in TestNG → Jupiter Jun 14, 2024
@Philzen
Copy link
Owner Author

Philzen commented Jun 15, 2024 •
edited
Loading

This feature is implemented and available on main via the org.openrewrite.java.testing.junit5.AddMissingNested recipe.

However it should be reviewed that inner classes that don't have both public and static are not annotated / changed, thus leaving this issue open for review now.

@Philzen Philzen reopened this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature or request must-have
Projects
TestNG → Jupiter
Status: In review
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Philzen