UsdView: Display resolved labels in attribute editor #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvmkuruc
reviewed
Sep 18, 2024
| @@ -5,7 +5,8 @@ | |||
| # https://openusd.org/license. | |||
| # | |||
|
|
|||
| from pxr import Usd, UsdGeom, UsdShade | |||
| from collections import defaultdict | |||
nvaszabo
force-pushed
the
nvaszabo/usdview-add-resolved-labels-to-attribute-editor
branch
from
3f9c8da to
7c02ddd
Compare
|
Filed as internal issue #USD-10151 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nvaszabo
force-pushed
the
nvaszabo/usdview-add-resolved-labels-to-attribute-editor
branch
from
7c02ddd to
cb279f6
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nvaszabo
force-pushed
the
nvaszabo/usdview-add-resolved-labels-to-attribute-editor
branch
2 times, most recently
from
8fd8f89 to
ad5e444
Compare
nvaszabo
force-pushed
the
nvaszabo/usdview-add-resolved-labels-to-attribute-editor
branch
from
ad5e444 to
dd36305
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…les in the attributes editor
nvaszabo
force-pushed
the
nvaszabo/usdview-add-resolved-labels-to-attribute-editor
branch
from
dd36305 to
7dfa6f6
Compare
|
bookshelf.zip |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…d-resolved-labels-to-attribute-editor
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks for the example file, it was helpful to validate the change on our end. We've completed our review and this should be merged shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This PR uses the
usdSemanticsschema and API to compute the taxonomies and the associated labels and display them inUsdView'sattribute editor under a new row namedResolved Labels.The
Resolved Labelsfor a selected prim include the labels on the prim itself and those on all its ancestors (inherited labels).For each taxonomy, the unique set of labels is computed and sorted lexicographically by the 'UsdSemantics.LabelsQuery.ComputeUniqueInheritedLabels()` API.
Performance considerations
The computation of direct and indirect taxonomies and their labels is instantaneous for prim hierarchies that are ~30 items deep with ~10 taxonomies and ~10 labels each. The same seems to lag just very slightly with hierarchies that are ~30 items deep and with a random number of maximum of 100 taxonomies, each with a random number of maximum of of 100 labels.
Fixes Issue(s)