Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegionConfigurations.VmSize not deserialized/parsed correctly #136

Open
emmanuel-jr opened this issue Aug 15, 2022 · 0 comments
Open

RegionConfigurations.VmSize not deserialized/parsed correctly #136

emmanuel-jr opened this issue Aug 15, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@emmanuel-jr
Copy link
Contributor

emmanuel-jr commented Aug 15, 2022

New CreateBuild Feature

RegionConfigurations override VmSize is not deserialized/parsed correctly from the BuildSettings.json file. BuildRegionParams has VmSize with type AzureVmSize however, VmSize is deserialized as a string so returns null

What we could do:

  • In our PlayFab C# SDK, we may want to add to BuildRegionParams class
...
[JsonProperty("AzureVmSize")]                // new addition
[JsonConverter(typeof(StringEnumConverter))] // new addition
public AzureVmSize? VmSize;
...

This could be applied to any other parameters we deserialise/serialise as JSON

  • Or create an AgentInterfaces class(eg. BuildRegionDetails.cs). It will basically be a duplicate of PlayFab.MultiplayerModels.BuildRegionParams but local to LocalMultiplayerAgent
@emmanuel-jr emmanuel-jr added the bug Something isn't working label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant