Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: delete cache-id parameter of setup-nix action #3180

Closed
develop7 opened this issue Jan 22, 2024 · 1 comment
Closed

ci: delete cache-id parameter of setup-nix action #3180

develop7 opened this issue Jan 22, 2024 · 1 comment
Assignees
@develop7
Labels
ci Related to CI setup nix related to Nix tooling

Comments

@develop7
Copy link
Collaborator

develop7 commented Jan 22, 2024 •
edited
Loading

So either add the cache there - or drop it here.

Since there is a separate cache warm-up step, single nix cache per OS, and no job does actually update the cache, the cache-id parameter could be safely dropped altogether. Thank you for the heads-up.

Originally posted by @develop7 in #3173 (comment)
@develop7 develop7 mentioned this issue Jan 22, 2024
Merged
@develop7 develop7 added ci Related to CI setup nix related to Nix tooling labels Jan 25, 2024
@develop7 develop7 self-assigned this Jan 25, 2024
@wolfgangwalther wolfgangwalther mentioned this issue Jan 27, 2024
Closed
@wolfgangwalther
Copy link
Member

I don't think we can drop cache-id, I am using it in #3211.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@develop7 develop7

Labels
ci Related to CI setup nix related to Nix tooling
Milestone
No milestone
Development

No branches or pull requests
2 participants
@develop7 @wolfgangwalther