[Bug] Fast Leaves are broken

[MetalKnight56]

Basically when enabling fast leaves, instead of making their transparent parts opaque/darken, they continue to be transparent, but without rendering the other side.

With Fast graphics:

Without

Expected behaviour:

[JT122406]

I will have to dive into this since we just set the render type with Mc normally it handles the rest so idk if it’s a midlander issue or something, what platform and Mc version are you using/have you tried any other platform or version

[MetalKnight56]

I will have to dive into this since we just set the render type with Mc normally it handles the rest so idk if it’s a midlander issue or something, what platform and Mc version are you using/have you tried any other platform or version

I've tried using the default forge launcher, on 47.2.20, 1.20.1. Switched launchers and also disabled all mods aside OhTheBiomes...

I've actually found out a bit about why this issue happens, apparently bwg doesn't define the rendering method in the block model for it's leaves. Take a look at how acacia leaves are structured:

{
  "parent": "minecraft:block/leaves",
  "textures": {
    "all": "minecraft:block/acacia_leaves"
  }
}

After i added that in a resourcepack it kinda works, but the thing is, the inbetweens (where it's currently transparent), become all black and not exactly a dark greenish as other leaves, so yeah, that's all i could gather out of it

[JT122406]

We do the samething as normal mc
{
"parent": "minecraft:block/leaves",
"render_type": "minecraft:cutout_mipped",
"textures": {
"all": "biomeswevegone:block/fir/leaves"
}
}
We also add in the render type in json as that's the way forge wants you to do rendertypes

[MetalKnight56]

We do the samething as normal mc

{

"parent": "minecraft:block/leaves",

"render_type": "minecraft:cutout_mipped",

"textures": {

"all": "biomeswevegone:block/fir/leaves"

}

}

We also add in the render type in json as that's the way forge wants you to do rendertypes

That's odd, hmm are you able to replicate this issue in your side ? Maybe it's something on my end

[JT122406]

So I can recreate it on NeoForge and Forge but on fabric it works fine which leaves me to believe it's an issue with how Forge like platforms handle the rendertype changing during graphic settings changes

[JT122406]

I'm gonna close this as there's nothing we can do on our side unless we use the Deprecated by forge way of using the vanilla map. This should be reported to forge as a issue with the rendertype not changing with the graphics properties

[MetalKnight56]

I'm gonna close this as there's nothing we can do on our side unless we use the Deprecated by forge way of using the vanilla map. This should be reported to forge as a issue with the rendertype not changing with the graphics properties

anything i can do? Should i update forge or something like that?

[JT122406]

No It just needs to be fixed by the forge team

[Onigeshi]

Hi, first of all sorry for "reviving" this, but I've encountered this recently as well and started looking to see if I can fix it with a resourcepack.. and it looks like removing the "render_type": "minecraft:cutout_mipped", from the models fixes it, at least with NeoForge on 1.21.1 (ver. 21.1.115). I haven't tested with fabric or other versions.

I'm not a modder but reading the documentation it looks like this field is optional and so far flying around the world I don't see any rendering weirdness of the leaves after removing this field.

https://docs.neoforged.net/docs/resources/client/models/#render-types

fast (tested using aspen leaf):

fancy (tested using aspen leaf):

fast settings flying over an entire zelkova forest after removing the render_type field:

Edit: after more testing, the only leaves having issues by removing the render_type are the Yucca Leaves

[JT122406]

NeoForge has changed somethings so I will look into it on there side, Forge I am working with on Fixing that can be found here and will be fixed once this pr is merged
1.21.1 MinecraftForge/MinecraftForge#10396
1.20.1 MinecraftForge/MinecraftForge#10393