Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Allow passing lists of secretRef and configMapRef names into worker.extraEnvVarsSecrets and worker.extraEnvVarsCMs, respectively. #421

Closed
tsviki-theator opened this issue Jan 9, 2025 · 1 comment · Fixed by #422
Closed

[feature] Allow passing lists of secretRef and configMapRef names into worker.extraEnvVarsSecrets and worker.extraEnvVarsCMs, respectively. #421

tsviki-theator opened this issue Jan 9, 2025 · 1 comment · Fixed by #422
Assignees
@mitchnielsen
Labels
customer-requested enhancement An improvement of an existing feature

Comments

@tsviki-theator
Copy link

In Prefect Worker Helm chart values, it is possible to pass a single name of a secretRef into worker.extraEnvVarsSecret and a single name of configMapRef into worker.extraEnvVarsCM values.

It is common to have multiple secrets used by different workloads and in some cases it is required to have these secrets loaded into the Prefect Worker (for example, when using a Worker with a Process Work Pool).

Today we must duplicate the code and create a new secret template that contains these secrets so it could be used by the Prefect Worker, and everyone hates to duplicate code 🫣

It would be nice to allow passing lists of secretRef names and configMapRef names into worker.extraEnvVarsSecrets and worker.extraEnvVarsCMs, respectively.
@tsviki-theator tsviki-theator changed the title [feature] Allow passing lists of secretRef names and configMapRef names into worker.extraEnvVarsSecrets and worker.extraEnvVarsCMs, respectively. [feature] Allow passing lists of secretRef and configMapRef names into worker.extraEnvVarsSecrets and worker.extraEnvVarsCMs, respectively. Jan 9, 2025
mitchnielsen added a commit that referenced this issue Jan 9, 2025
@mitchnielsen
Add extraEnvVarsCMs for multiple ConfigMaps
921fc95 
Adds support for definining multiple ConfigMaps in the Worker
Deployment.

Related to #421
mitchnielsen added a commit that referenced this issue Jan 9, 2025
@mitchnielsen
Add extraEnvVarsSecrets for multiple Secrets
65dbdd6 
Adds support for defining multiple Secrets in the Worker Deployment.

Related to #421
@mitchnielsen mitchnielsen self-assigned this Jan 9, 2025
@mitchnielsen mitchnielsen added the enhancement An improvement of an existing feature label Jan 9, 2025
@mitchnielsen mitchnielsen mentioned this issue Jan 9, 2025
Merged
@mitchnielsen
Copy link
Contributor

Thanks for reaching out @tsviki-theator, sounds like a reasonable request. I opened #422 - let me know if that meets your needs 👍🏼

mitchnielsen added a commit that referenced this issue Jan 9, 2025
@mitchnielsen
feat(worker): support env vars from multiple ConfigMaps, Secrets (#422)
5df23fe 
* Add extraEnvVarsCMs for multiple ConfigMaps

Adds support for definining multiple ConfigMaps in the Worker
Deployment.

Related to #421

* Add extraEnvVarsSecrets for multiple Secrets

Adds support for defining multiple Secrets in the Worker Deployment.

Related to #421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitchnielsen mitchnielsen

Labels
customer-requested enhancement An improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(worker): support env vars from multiple ConfigMaps, Secrets PrefectHQ/prefect-helm
3 participants
@mitchnielsen @jamiezieziula @tsviki-theator