Feat: 버튼 컴포넌트 기본 작업 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsconfig.json에 moduleResolution: bundle -> node로 변경해서 해결
- postcss.config.mjs -> postcss.config.cjs로 변경 - tsconfig.json -> **/*.cjs 추가 - preview.ts -> import '../styles/tailwind.css'; 추가
rai-95
reviewed
Apr 30, 2024
styles/tailwind.css
Outdated
There was a problem hiding this comment.
globals.css가 tailwind.css로 경로가 변경되서 실행시 경로 에러가 나는거 같습니다!!
나중에 변경해주시면 좋을거 같아요!
There was a problem hiding this comment.
@rai-95 성은님! 혹시 제거에서는 돌아가는데(ㅋㅋㅋㅋㅋ) 한번 확인 부탁드려도 될까요?
| import { PropsWithChildren } from 'react'; | ||
| import { ButtonContext } from '../modules/ButtonStateContext'; | ||
|
|
||
| export interface IButtonMain extends PropsWithChildren, VariantProps<typeof buttonMainVariants> { |
There was a problem hiding this comment.
👍👍 좋습니다!
children 인터페이스 부분 통일하면 좋을거 같아요!
ButtonMain은 extends PropsWithChildren로 작성되어 있고 ButtonLabel은 children: React.ReactNode 로 다르게 작성된거 같아서요!
There was a problem hiding this comment.
@rai-95 헉!! 좋습니다 ㅎㅎㅎ 바로 바꾸겠습니다!
PropsWithChildren으로 통일하면 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
#5
구현 내용