Porting of MedNIST DDPM model-zoo from MONAI Generative #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erify_bundle to pass the check for model.pt, since the requirement for two models (autoencoder and diffusion_model) makes sense for them to keep their specific names. Modification of inference.json to add dummy attributes to pass the ConfigWorkflow check. Modification of large_files.yml so that models are .pt and not .pth.
for more information, see https://pre-commit.ci
virginiafdez
changed the title
ericspod
reviewed
Jan 13, 2025
| val_mean_abs_error: | ||
| _target_: MeanAbsoluteError | ||
| output_transform: $monai.handlers.from_engine([@pred, @label]) | ||
| metric_cmp_fn: '$scripts.inv_metric_cmp_fn' |
There was a problem hiding this comment.
If you wanted to add operator to your imports you could do metric_cmp_fn: '$operator.lt' and eliminate the code definition. I think this will work just fine but needs checking.
Add LICENSE file.
ericspod
approved these changes
Jan 24, 2025
|
/build |
|
|
Hi @virginiafdez, you can also try this check locally. |
ericspod
reviewed
Jan 26, 2025
The issue here is that the CICD test isn't loading both common.yaml and inference.yaml I think? It needs common.yaml for the definitions, maybe we should just copy those definitions into the other files for now. |
Yes, for now CICD didn't take the common.yaml into consideration. We may need enhance the CICD or directly copy the things out for now. |
I spoke to @virginiafdez and we'll copy the contents of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial porting from the Generative model-zoo of the mednist-ddpm model (https://github.com/Project-MONAI/GenerativeModels/tree/main/model-zoo/models/mednist_ddpm/bundle).
The bundle files are tested within the docs/2d_ddpm_bundle_tutorial.ipynb
Status
Ready
Please ensure all the checkboxes:
versionandchangeloginmetadata.jsonif changing an existing bundle.CONTRIBUTING.md).monai,pytorchandnumpyare correct inmetadata.json./home/your_name/for"bundle_root").