Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temperature and errors checks #252

Open
yordanov-alexandar opened this issue Sep 3, 2022 · 0 comments
Open

Add temperature and errors checks #252

yordanov-alexandar opened this issue Sep 3, 2022 · 0 comments

Comments

@yordanov-alexandar
Copy link

Hi
I am making this project as a gift for my father. He is not a technical person so I added a check to not show the scrolling errors as they will only confuse him. In the past he has also expressed desire to see only the time and no weather info so I added another check to not show the temperature(the only weather info that is not already behind a checkbox option) scrolling.
During the testing of these two additions I had a lot of crashes and subsequent restarts of the clock. After some googling and looking at the stacktrace (I have zero experience with C++ and Arduino) I decided that the problem is with string concatenations so I commented some of the Serial.println code and had no problems since then. This might (or might not :) ) solve some of the issues I saw here where people are having crashes. This for example sounds exactly like what was happening to me. I have no idea if that problem can be solved in another way.
Here is the patch for these changes errors_temp_checks.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant