Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next should point to another site in the ring #1

Open
vinayak-mehta opened this issue Jan 3, 2025 · 1 comment · May be fixed by #5
Open

Next should point to another site in the ring #1

vinayak-mehta opened this issue Jan 3, 2025 · 1 comment · May be fixed by #5
Assignees

Comments

@vinayak-mehta
Copy link

Hey there! Thanks for making this webring, I just added myself to it!

I saw that the next button on my site points back to the webring (probably because I added myself last) which seems redundant because I already point to the webring with the main link. It could be cool to point to the first site of the webring for the last person.

@Qwuke
Copy link
Owner

Qwuke commented Jan 10, 2025

Ah, great point!

So currently, the first+last site will always point to the main site, which ends up being redundant for everyone including the RC ring link anyways.

We can thankfully update this in both the JS file and the ring.recurse.com/links without requiring changes for the ring users :)

This change can also tie into eliminating the "beginning" and "end" sites on the ring - I don't think it's in the spirit of sharing cool sites to have a ring order based on when someone joined the ring itself, especially if the ring keeps growing.

@Qwuke Qwuke self-assigned this Jan 20, 2025
@Qwuke Qwuke linked a pull request Jan 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants