Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Community Euler Samplers #10

Open
iwr-redmond opened this issue Dec 5, 2024 · 2 comments
Open

[Feature Request] Community Euler Samplers #10

iwr-redmond opened this issue Dec 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@iwr-redmond
Copy link

Despite the arrival of FLUX, I reckon SD15 is still going strong. As you have recently implemented some extra samplers in the dev version, would it be possible to add the Extra Euler Samplers? They are often recommended for improving hand generation in SD15 checkpoints.

The process should be pretty similar to the work already undertaken.

TY

@R3gm R3gm added the enhancement New feature or request label Dec 6, 2024
R3gm added a commit that referenced this issue Dec 6, 2024
@iwr-redmond
Copy link
Author

Thanks for putting in the Max and Negative samplers for testing. Looking at the code for the other community Euler samplers, it seems these require greater integration with the k-diffusion package.

Diffusers has a wrapper for k-diffusion that makes this plausible. The key part is at lines 136-147, which searches the k_diffusion/samplers.py file.

Perhaps the remaining extra samplers could be put together in a single file and then polled in a similar manner? (As an aside, this might also provide an opportunity to offer the original k-diffusion samplers where they are of higher quality to the diffusers re-implementations.)

@R3gm
Copy link
Owner

R3gm commented Dec 14, 2024

Totally makes sense
For now, though, I’m sticking with the Diffusers schedulers since they’re already pretty built-in with what I’m doing. However, leveraging the k-diffusion wrapper is definitely a good idea for future enhancements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants