Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Possible Feature] ELLA for SD1.5 #20

Open
iwr-redmond opened this issue Jan 3, 2025 · 1 comment
Open

[Possible Feature] ELLA for SD1.5 #20

iwr-redmond opened this issue Jan 3, 2025 · 1 comment

Comments

@iwr-redmond
Copy link

iwr-redmond commented Jan 3, 2025

I have come across code that integrates Tencent's criminally underused ELLA with Diffusers. Daniel Sandner's article from last year has some good examples of what ELLA can achieve with his Photomatix SD1.5 model.

The code is contained in a third-party fork, with the model code being here and the pipeline code being here. The pipeline integrates Loras, IP Adapters, and PAG, which I think is more than the reference code was capable of (the ComfyUI implementation supporting Loras and ControlNets).

There are some issues that the pipeline author has flagged, suggesting that implementation may be of moderate complexity. Note that despite being almost entirely relegated to ComfyUI, the original ELLA reference code was implemented using Diffusers.

I reckon ELLA would make a good pair with HiDiffusion.

@iwr-redmond
Copy link
Author

iwr-redmond commented Jan 12, 2025

It is possible that the just-released LLM4Gen would serve a similar purpose without as much adaptation. The code appears to combine CLIP and LLM together, rather than requiring separate prompts like ELLA. While the demo code shows nothing about Loras, Controlnets, etc, the author says that it should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant