managementportal postgres password

[afolarin]

postgres_password: password should this not be in the management portal chart values?

chart/management-portal/values.yaml currently references postgres.password:

....
# Configuration of the Postgres data base to store data from Management Portal
postgres:
  # -- host name of the postgres db
  host: postgresql
  # -- post of the postgres db
  port: 5432
  # -- database name
  database: managementportal
  # -- additional JDBC connection parameters e.g. sslmode=verify-full
  connection_parameters: ""
  # -- postgres user
  user: postgres
  # -- password of the postgres user
  password: password
  ssl:
    # -- set to true of the connecting to postgres using SSL
    enabled: false
    keystorepassword: keystorepassword
....

then change below these to use .Values.postgres.password ?

helmfile.d/20-upload.yaml-      - name: postgresqlPassword
helmfile.d/20-upload.yaml:        value: {{ .Values.radar_upload_postgres_password }}
helmfile.d/20-upload.yaml-      - name: replication.password
helmfile.d/20-upload.yaml:        value: {{ .Values.radar_upload_postgres_password }}
helmfile.d/20-upload.yaml-
--
helmfile.d/20-upload.yaml-      - name: postgres.password
helmfile.d/20-upload.yaml:        value: {{ .Values.radar_upload_postgres_password }}
helmfile.d/20-upload.yaml-      {{ if hasKey .Values.management_portal.oauth_clients "radar_upload_backend" }}
--
helmfile.d/10-managementportal.yaml-      - name: postgresqlPassword
helmfile.d/10-managementportal.yaml:        value: {{ .Values.postgres_password }}
helmfile.d/10-managementportal.yaml-      - name: replication.password
helmfile.d/10-managementportal.yaml:        value: {{ .Values.postgres_password }}

[keyvaann]

postgres_password is for the PostgreSQL instance that is used commonly between different applications such as Management Portal, App config and Rest backend so we used a common variable to define password for all of these applications to avoid repetition.

Later on we added separate instances of PostgreSQL for Upload connector and Dashboard which have their own password defined separately.

[iDmple]

I'm hitting this bug. This is very confusing. I had to manually change the password in charts/management-portal/values.yaml

Can we have a clearer password management in production.yaml?

[afolarin]

Agreed, we'd definitely would welcome some input tidying up password definitions and providing better semantics

[keyvaann]

You don't need to change anything in charts and you can define the passwords in production.yaml and the secrets file.
However there can be better documentation on how to fill those files.