Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmake smart-image 制作 fat 格式文件会失败 #65

Closed
unicornx opened this issue Nov 13, 2024 · 1 comment · Fixed by #66
Closed

xmake smart-image 制作 fat 格式文件会失败 #65

unicornx opened this issue Nov 13, 2024 · 1 comment · Fixed by #66

Comments

@unicornx
Copy link
Contributor

unicornx commented Nov 13, 2024

具体参考 #64,fat image 制作实际上失败了,但没有提示,而且不会报错还会生成 img,导致用户很难察觉和定位问题。

建议改进措施:

  • cp 失败强制终止命令,补一个提示并退出
  • 失败情况下不要再生成 fat.img
  • readme 中建议对 fat 方式加一些说明,建议用户在失败的情况下增加 -s 选项调整生成 image 大小。
@unicornx
Copy link
Contributor Author

第三条建议看上去被 ignore 了 ......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant