Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error handling in ContextBrokerClient #377

Open
paul-l1 opened this issue Jan 23, 2025 · 2 comments · May be fixed by #378
Open

fix error handling in ContextBrokerClient #377

paul-l1 opened this issue Jan 23, 2025 · 2 comments · May be fixed by #378

Comments

@paul-l1
Copy link

paul-l1 commented Jan 23, 2025

The error handling for requests.RequestException in ContextBrokerClient tries to access err.response.status_code without checking if err.response is None. This can raise an AttributeError.
@djs0109
Copy link
Contributor

djs0109 commented Jan 23, 2025

This issue seems related with #335. @paul-l1 could you have a look, whether the fix there would also resolve the error you found?

@paul-l1 paul-l1 linked a pull request Jan 23, 2025 that will close this issue
Open
@paul-l1
Copy link
Author

paul-l1 commented Jan 23, 2025

#335 is not fixing the same issue, therefore I created a Pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix error handling in cb.py paul-l1/FiLiP
2 participants
@djs0109 @paul-l1