Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Neumorphism Carousel component responsive #1456

Closed
wants to merge 2 commits into from

Conversation

Arisha2902
Copy link

@Arisha2902 Arisha2902 commented Jan 13, 2025

Fixes Issue🛠️

Closes #1417

Description👨‍💻

Made Neumorphism Carousel Responsive. Made Carousel compatible on all type of devices.

Type of Change📄

  • Style (non-breaking change which improves responsiveness)
  • Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

Screenshot (329)

Screenshot (330)

Screenshot (331)

Screenshot (332)

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit 46ae817
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/6785e3f6450a2d0008d57dec
😎 Deploy Preview https://deploy-preview-1456--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Arisha2902, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Rakesh9100
Copy link
Owner

Please edit the PR template above and fill every asked details properly, don't close this PR and create a new one @Arisha2902

@Rakesh9100 Rakesh9100 changed the title made neumorphism responsive FIX #1417 Made Neumorphism Carousel component responsive Jan 14, 2025
@Arisha2902
Copy link
Author

@Rakesh9100 , I made the chnages in PR Template , do check it

@Rakesh9100
Copy link
Owner

Check the recording below and the deploy preview properly for every screen sizes, it is not yet fully responsive @Arisha2902

recording.mp4

@Arisha2902
Copy link
Author

@Rakesh9100 ,sorry I can't make that change , it is beyond my reach. Quiet Hard

@Rakesh9100
Copy link
Owner

Should I close your PR and unassign you then @Arisha2902

@Arisha2902
Copy link
Author

@Rakesh9100 , I have made changes in container but is not able to " justify-content " so If you could give me some points in SWOC5 , it could be better .

Rest for this issue I can't help any more .
So if possible assign me some points and close this issue

@Rakesh9100
Copy link
Owner

I would have merged it, but the responsiveness is not fixed yet. I've opened this issue to address it properly and will assign an Intermediate or Advanced level based on the work done @Arisha2902

@Rakesh9100 Rakesh9100 closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] Make Neumorphism Carousel component responsive
2 participants