From aa0f7f7a11ac1b5c9c5da2d1ce1798f258af6439 Mon Sep 17 00:00:00 2001 From: mattip Date: Sat, 21 Sep 2019 19:57:35 +0300 Subject: [PATCH] BUILD, DOC: fix 14518, add release note --- doc/release/upcoming_changes/14518.change.rst | 18 ++++++++++++++++++ numpy/distutils/command/build_src.py | 2 +- 2 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 doc/release/upcoming_changes/14518.change.rst diff --git a/doc/release/upcoming_changes/14518.change.rst b/doc/release/upcoming_changes/14518.change.rst new file mode 100644 index 000000000000..f7b782825402 --- /dev/null +++ b/doc/release/upcoming_changes/14518.change.rst @@ -0,0 +1,18 @@ +Add options to quiet build configuration and build with ``-Werror`` +------------------------------------------------------------------- +Added two new configuration options. During the ``build_src`` subcommand, as +part of configuring NumPy, the files ``_numpyconfig.h`` and ``config.h`` are +created by probing support for various runtime functions and routines. +Previously, the very verbose compiler output during this stage clouded more +important information. By default the output is silenced. Running ``runtests.py +--debug-configure`` will add ``-v`` to the ``build_src`` subcommand, which +will restore the previous behaviour. + +Adding ``CFLAGS=-Werror`` to turn warnings into errors would trigger errors +during the configuration. Now ``runtests.py --warn-error`` will add +``--warn-error`` to the ``build`` subcommand, which will percolate to the +``build_ext`` and ``build_lib`` subcommands. This will add the compiler flag +to those stages and turn compiler warnings into errors while actually building +NumPy itself, avoiding the ``build_src`` subcommand compiler calls. + +(`gh-14527 `__) diff --git a/numpy/distutils/command/build_src.py b/numpy/distutils/command/build_src.py index 664b52e37684..af8cec08ac19 100644 --- a/numpy/distutils/command/build_src.py +++ b/numpy/distutils/command/build_src.py @@ -79,7 +79,7 @@ def initialize_options(self): self.swig_opts = None self.swig_cpp = None self.swig = None - self.verbose = False + self.verbose = None def finalize_options(self): self.set_undefined_options('build',