Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decomposition of marginals does not decompose namedtuple when other marginals are present #440

Open
wouterwln opened this issue Jan 22, 2025 · 0 comments
Assignees

Comments

@wouterwln
Copy link
Member

wouterwln commented Jan 22, 2025

if we have q(x,y)q(z) around a node, and we compute the marginal q(x,y) when one of the incoming messages is PointMass, we return the tuple (x = q_x, y = q_y). This is decomposed only when q(z) is not present.

Bug is here:

function score(::AverageEnergy, fform, ::Val, marginals::Tuple{<:Marginal{<:NamedTuple{N}}}, meta) where {N}

The dispatch of the marginals argument should be wider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants