This repository has been archived by the owner on Dec 3, 2020. It is now read-only.
forked from whipper-team/whipper
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathHACKING
72 lines (57 loc) · 2.67 KB
/
HACKING
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
style guide
-----------
Where possible when writing new code, try to stay as PEP8 compliant as possible.
We understand that large portions of the codebase are not, but part of our
ongoing efforts is to clean up whipper.
major data structures
---------------------
- image.table.Track: A list of track properties, including a list of indexes,
the isrc, cdtext, pre-emphasis flag, track number, and track type (audio
or data)
- image.table.Index: A list of track index properties, including the track's path,
relative and absolute offsets within the track & disc, respectively, as
well as the track number and counter.
- image.table.Table: An ordered list of Track objects, with their leadouts,
cdtext, and catalog numbers.
- image.cue.CueFile: Generates an image.table.Table from a .cue file from an
existing rip.
- image.toc.TocFile: Generates an image.table.Table from a .toc file generated
by `cdrdao read-toc`.
notes
-----
test: single rip of kings of leon - only by the night
track 1: frame start 0, 17811 CD frames,
track 2: frame start 17811, 18481 CD frames
ARCue.pl says 2c15499a
track 11: frame start 166858, 25103 CD frames (14760564 audio frames)
191961 total CD frames
unicode
-------
- All text files should be read and written as unicode.
- All strings that came from the outside should be converted to unicode objects.
- Use asserts liberally to ensure this so we catch problems earlier.
- All gst.parse_launch() pipelines should be passed as utf-8; use
encode('utf-8')
- whipper.extern.log.log is not unicode-safe; don't pass it unicode objects;
for example, always use %r to log paths
- run with RIP_DEBUG=5 once in a while to catch unicode/logging errors.
- Also use unicode prefix/suffix in tempfile.* methods; to force unicode.
- filesystems on Unix do not have an encoding. file names are bytes.
However, most distros default to a utf-8 interpretation
- You can either treat paths as byte strings all the way without interpreting
(even when writing them to other files), or assume utf-8 on in and out.
- also direct output to a file; redirection sets codec to ASCII and brings out
unicode bugs
CDROMS
------
PLEXTOR CD-R PX-W8432T Read offset of device is: 355.
test discs
----------
Julie Roberts - Julie Roberts: cdparanoia paranoid mode has a false positive
jitter correction and silently rips the incorrect track. ripping with
-Z rips the correct track.
Rush - Test for Echo: has 31 frames of silence in the first track's pregap,
test for HTOA detection regressions.
The Strokes - Someday (promo): has 1 frame silence marked as SILENCE
The Pixies - Surfer Rosa/Come on Pilgrim: has pre-gap, and INDEX 02 on TRACK 11
Florence & The Machine - Lungs: data track