We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
When running the preview-docs command using the Docker image, it doesn't respond to ctrl+c to exit.
preview-docs
ctrl+c
To Reproduce Steps to reproduce the behaviour:
Create a valid openapi.yaml file.
openapi.yaml
Run this command:
docker run --rm -p 8080:8080 -v $PWD:/spec redocly/cli preview-docs \ openapi.yaml --use-community-edition --host 0.0.0.0
Try to exit by pressing ctrl+c as you would do with the npm version
Note that redocly hasn't exited.
Note, I have also tried adding the -t and -i flags to the docker command.
-t
-i
docker
Expected behaviour
The docker container exits and control is returned to the shell in the terminal.
i.e. I expected it to behave in the same way as docker run redis does when you press ctrl+c.
docker run redis
Redocly Version(s)
$ docker run --rm redocly/cli --version 1.22.0
Node.js Version(s)
Node.js
Whatever is in the Docker image.
OS, environment
MacOS 14.6.1 (Apple Silicon). Docker Desktop 4.31.0 (153195).
The text was updated successfully, but these errors were encountered:
I confirm this is a bug. Thanks for reporting it!
Sorry, something went wrong.
Works for me if I add the --init flag to the docker run command:
--init
docker run
docker run --init --rm -p 8080:8080 -v $PWD:/spec redocly/cli preview-docs \ openapi.yaml --use-community-edition --host 0.0.0.0
See: https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#handling-kernel-signals (requires Docker 1.13)
Maybe just the docs need updating.
No branches or pull requests
Describe the bug
When running the
preview-docs
command using the Docker image, it doesn't respond toctrl+c
to exit.To Reproduce
Steps to reproduce the behaviour:
Create a valid
openapi.yaml
file.Run this command:
Try to exit by pressing
ctrl+c
as you would do with the npm versionNote that redocly hasn't exited.
Note, I have also tried adding the
-t
and-i
flags to thedocker
command.Expected behaviour
The docker container exits and control is returned to the shell in the terminal.
i.e. I expected it to behave in the same way as
docker run redis
does when you pressctrl+c
.Redocly Version(s)
Node.js
Version(s)Whatever is in the Docker image.
OS, environment
MacOS 14.6.1 (Apple Silicon). Docker Desktop 4.31.0 (153195).
The text was updated successfully, but these errors were encountered: