From 42650f8ace36efbf43c7092a82b7b5de402c4448 Mon Sep 17 00:00:00 2001 From: DivadNojnarg Date: Fri, 4 Oct 2024 17:43:41 +0200 Subject: [PATCH] fix shinyapps.io links --- R/preview_mobile.R | 1 - README.md | 3 +-- cran-comments.md | 2 ++ man/preview_mobile.Rd | 1 - vignettes/pwa.Rmd | 3 +-- vignettes/shinyMobile-tools.Rmd | 3 +-- 6 files changed, 5 insertions(+), 8 deletions(-) diff --git a/R/preview_mobile.R b/R/preview_mobile.R index 5195a5d4..fa9afb50 100644 --- a/R/preview_mobile.R +++ b/R/preview_mobile.R @@ -20,7 +20,6 @@ #' library(shiny) #' library(shinyMobile) #' preview_mobile(appPath = "~/whatever", device = "galaxyNote8") -#' preview_mobile(url = "https://dgranjon.shinyapps.io/miniUI2DemoMd", device = "ipadMini") #' } preview_mobile <- function(appPath = NULL, url = NULL, port = 3838, device = c( diff --git a/README.md b/README.md index d95a8264..845e540c 100644 --- a/README.md +++ b/README.md @@ -59,7 +59,6 @@ Where `APP_PATH` is the app location. Currently, it only works if the app is **i - A valid `service-worker.js`. - A valid web manifest (`manifest-webmanifest`). Don't forget to change the `start_url` property to the path of your app. -For instance, the following app hosted at https://dgranjon.shinyapps.io/rstudio-global-2021-calendar/, has the `/rstudio-global-2021-calendar/` path. - As a bonus a valid `offline.html` fallback, which is displayed when the app is offline. - A valid set of icons. There are tools such as [appsco](https://appsco.pe/developer/splash-screens) and [app-manifest](https://app-manifest.firebaseapp.com), to create those custom icons and splash screens, if you need to. @@ -79,7 +78,7 @@ The first step is to deploy your app somewhere. It doesn't matter where (shinyap Then, you can follow these steps to install your app on your mobile device.
-Copy the URL of your app in your mobile web browser (iOS: Safari and Andoid: Chrome). In this example this is: https://dgranjon.shinyapps.io/miniUI2Demo/. It opens like a classic web app, with top and bottom ugly navigation bars that are part of the browser UI. +Copy the URL of your app in your mobile web browser (iOS: Safari and Andoid: Chrome). It opens like a classic web app, with top and bottom ugly navigation bars that are part of the browser UI. - Select the share button located in the bottom bar of your iPhone/iPad For Android, you may do something similar. Importantly, Chrome for iOS does not support this feature, that's why we recommend using Safari. - Click on "Add to Home Screen" diff --git a/cran-comments.md b/cran-comments.md index 35c06ea2..2d916d96 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -6,4 +6,6 @@ ## R CMD check results There were no ERRORs or WARNINGs or NOTEs. +## Re-submission +Update links. diff --git a/man/preview_mobile.Rd b/man/preview_mobile.Rd index 93eabeab..45f1559b 100644 --- a/man/preview_mobile.Rd +++ b/man/preview_mobile.Rd @@ -44,6 +44,5 @@ if (interactive()) { library(shiny) library(shinyMobile) preview_mobile(appPath = "~/whatever", device = "galaxyNote8") - preview_mobile(url = "https://dgranjon.shinyapps.io/miniUI2DemoMd", device = "ipadMini") } } diff --git a/vignettes/pwa.Rmd b/vignettes/pwa.Rmd index 216da248..5531a137 100644 --- a/vignettes/pwa.Rmd +++ b/vignettes/pwa.Rmd @@ -80,7 +80,6 @@ Where `APP_PATH` is the app location. Currently, it only works if the app is **i - A valid `service-worker.js`. - A valid web manifest (`manifest-webmanifest`). Don't forget to change the `start_url` property to the path of your app. -For instance, the following app hosted at https://dgranjon.shinyapps.io/rstudio-global-2021-calendar/, has the `/rstudio-global-2021-calendar/` path. - As a bonus a valid `offline.html` fallback, which is displayed when the app is offline. - A valid set of icons. There are tools such as [appsco](https://appsco.pe/developer/splash-screens) and [app-manifest](https://app-manifest.firebaseapp.com), to create those custom icons and splash screens, if you need to. @@ -100,7 +99,7 @@ The first step is to deploy your app somewhere. It doesn't matter where (shinyap Then, you can follow these steps to install your app on your mobile device.
-Copy the URL of your app in your mobile web browser (iOS: Safari and Andoid: Chrome). In this example this is: https://dgranjon.shinyapps.io/miniUI2Demo/. It opens like a classic web app, with top and bottom ugly navigation bars that are part of the browser UI. +Copy the URL of your app in your mobile web browser (iOS: Safari and Andoid: Chrome). It opens like a classic web app, with top and bottom ugly navigation bars that are part of the browser UI. - Select the share button located in the bottom bar of your iPhone/iPad For Android, you may do something similar. Importantly, Chrome for iOS does not support this feature, that's why we recommend using Safari. - Click on "Add to Home Screen" diff --git a/vignettes/shinyMobile-tools.Rmd b/vignettes/shinyMobile-tools.Rmd index 3a0a39c6..6f9861be 100644 --- a/vignettes/shinyMobile-tools.Rmd +++ b/vignettes/shinyMobile-tools.Rmd @@ -38,8 +38,7 @@ library(shiny) library(shinyMobile) preview_mobile(appPath = system.file("examples/gallery/app.R", package = "shinyMobile"), device = "iphoneX") - -preview_mobile(url = "https://dgranjon.shinyapps.io/miniUI2DemoMd", device = "ipadMini") +# This also works with a remote app url hosted on shinyapps.io ... ``` The local preview is a 4 steps process: