Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-lock.json should be committed to git #38

Closed
jayenashar opened this issue Jun 14, 2023 · 2 comments
Closed

package-lock.json should be committed to git #38

jayenashar opened this issue Jun 14, 2023 · 2 comments

Comments

@jayenashar
Copy link
Collaborator

this ensures that npm installs the same version of packages for everyone. people should use npm ci when creating a production build instead of npm install.

(i use yarn not npm or i'd submit a PR)

@ahasselbring
Copy link
Member

Yeah, this is part of what I meant by #13.

ahasselbring added a commit that referenced this issue Jun 14, 2023
as suggested by jayen
@jayenashar
Copy link
Collaborator Author

jayenashar commented Jun 14, 2023

oh i saw that issue but only saw cargo mentioned so i skipped it. i missed the package.json mentions.

normally for node, you have both package.json and package-lock.json in git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants