Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Delete/File upload modal is now improved and Reaction emoji is added in message toolbar . #914

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

feat: Delete/File upload modal is now improved and Reaction emoji is added in message toolbar . #914

wants to merge 9 commits into from

Conversation

thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Jan 16, 2025 •
edited
Loading

Brief Title

The Delete modal now follows RC’s standard labels and no longer displays actual content. The message toolbar shows a proper reaction emoji icon, and the file upload modal now includes validation to prevent empty submissions while improving accessibility. Additionally, usernames are now clickable, displaying user info, with an error fallback if the data cannot be fetched.

Acceptance Criteria fulfillment

  • improving Delete modal- removed showing actual content, and change some default labels to what RC follows
  • Add reaction emoji in message toolbar previously it is showing emoji icon
  • improve fileUpload modal - showing error if field is empty, fields are accessible through labels, does not send file if file-name is empty
  • Made username clickable showing userInfo and if does not able to fetch userInfo then show error.

Fixes #913

Video/Screenshots

Screencast.from.2025-02-09.15-08-38.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-914 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@dhairyashiil
Copy link
Contributor

Hello @thepiyush-303,

Has the behavior changed for all messages, or only for messages with attachments like audio, video, files, and images?

For normal text messages, the current delete modal works well by displaying the message content in the modal. However, for messages with attachments, it simply displays the attachment. We can improve this by showing the filename and file description along with the attachment.

This would give the user a clear understanding of which message they are deleting.

Currently, the following texts are displayed:

  1. Are you sure?
  2. You will not be able to recover this message!
    While both are based on RC terminology, they do not provide the user with a clear idea of which message they are actually deleting.

The approach mentioned above would certainly enhance the UI and improve the user experience.

@thepiyush-303
Copy link
Contributor Author

I think we should follow Rocket's behaviour in EC also, rest will be decided by @Spiral-Memory

@Spiral-Memory
Copy link
Collaborator

Hi @thepiyush-303
Make a detailed video of your changes showing all cases

@thepiyush-303
Copy link
Contributor Author

@Spiral-Memory
it will show the same modal for all types of messages.

Screencast.from.2025-01-28.18-33-52.mp4

@thepiyush-303 thepiyush-303 marked this pull request as draft February 7, 2025 11:32
@thepiyush-303 thepiyush-303 changed the title feat: Delete modal is now improved and Reaction emoji is added in message toolbar. feat: Delete/File upload modal is now improved and Reaction emoji is added in message toolbar . Feb 9, 2025
@thepiyush-303 thepiyush-303 marked this pull request as ready for review February 9, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Delete/ fileUpload modal and made usernames clickable.
3 participants
@thepiyush-303 @dhairyashiil @Spiral-Memory