Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : File_Attachement_UI_Not_Correct #952

Open
AyushKumar123456789 opened this issue Feb 3, 2025 · 0 comments · May be fixed by #953
Open

Fix : File_Attachement_UI_Not_Correct #952

AyushKumar123456789 opened this issue Feb 3, 2025 · 0 comments · May be fixed by #953
Labels
bug Something isn't working

Comments

@AyushKumar123456789
Copy link
Contributor

AyushKumar123456789 commented Feb 3, 2025

Description:

This PR fixes three issues with attachment UI rendering:

  1. File Description Overlap: File attachments (such as PDFs, videos, etc.) previously rendered their description/message on a single line. This has been fixed by ensuring proper line breaks and spacing.
  2. Missing Collapse/Expand Button for Files: Unlike image, audio, and video attachments, file attachments lacked a collapse/expand button. This has now been added so users can toggle file details.
  3. Audio Attachment Multi-line UI Issue: When an audio attachment's associated message spans multiple lines, the text was overlapping. The problematic CSS (such as an overly restrictive line-height) has been adjusted to render multi-line text correctly.

Steps to reproduce:

  1. Send a message with a file attachment (e.g., a PDF or video) that includes a multi-line description.
  2. Observe that the description renders as one continuous line and overlaps.
  3. Notice that there is no collapse/expand button for the file attachment.
  4. Repeat the process with an audio attachment containing multi-line text to see the overlapping issue.

Expected behavior:

  • File attachments should render their description/message properly line by line.
  • A collapse/expand button should be available for file attachments, allowing users to hide or reveal additional file details.
  • Audio and other file attachments should display multi-line messages correctly without overlapping.

Actual behavior:

Image

Image

  • The file attachment description/message appears on one line, causing overlapping when the text is long.
  • No collapse/expand functionality exists for file attachments.
  • Audio attachments with multi-line messages experience text overlapping due to incorrect CSS settings.
@AyushKumar123456789 AyushKumar123456789 added the bug Something isn't working label Feb 3, 2025
@AyushKumar123456789 AyushKumar123456789 linked a pull request Feb 3, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant