fix: improve filename generation in shareview #6101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes the issue where missing filenames were default to a
.jpg
extension. It now attempts to get the filename from the storage path, and if that's not possible, it falls back to using the file extension based on the MIME type. This ensures that files are named correctly with the appropriate extension.Issue(s)
closes #6100
How to test or reproduce
Send an mp4 video and observe the filename shown during upload
Screenshots
Before:
After:
Types of changes
Checklist
Further comments
N/A