Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve filename generation in shareview #6101

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Rohit3523
Copy link
Contributor

@Rohit3523 Rohit3523 commented Jan 22, 2025

Proposed changes

This PR fixes the issue where missing filenames were default to a .jpg extension. It now attempts to get the filename from the storage path, and if that's not possible, it falls back to using the file extension based on the MIME type. This ensures that files are named correctly with the appropriate extension.

Issue(s)

closes #6100

How to test or reproduce

Send an mp4 video and observe the filename shown during upload

Screenshots

Before: Screenshot 2025-01-22 at 4 13 30 PM
After: Screenshot 2025-01-22 at 4 12 41 PM

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Extension Incorrectly Shown as .jpg During MP4 Upload
1 participant