Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove UI date slider, fixes #4 #20

Merged
merged 2 commits into from
Aug 14, 2024
Merged

remove UI date slider, fixes #4 #20

merged 2 commits into from
Aug 14, 2024

Conversation

andysouth
Copy link
Contributor

@andysouth andysouth commented Aug 14, 2024

Fixes #4

@andysouth andysouth requested a review from milanmlft August 14, 2024 09:13
Copy link
Member

@milanmlft milanmlft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @andysouth! Thanks for getting this in. Happy for you to merge once all the checks have passed.

@andysouth
Copy link
Contributor Author

Thanks @milanmlft, seems the linter generates a large number of errors from other code - is it OK for me to ignore those & merge ?

@milanmlft
Copy link
Member

Yeah sorry about that, I'm working on a fix for the linting CI. But I'll merge this PR in already.

@milanmlft milanmlft merged commit ce78099 into main Aug 14, 2024
1 of 2 checks passed
@milanmlft milanmlft deleted the remove-date-slider branch August 14, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide on date range selection UI
2 participants