From b64e1f594a122608421e1955232641819b4918d0 Mon Sep 17 00:00:00 2001 From: Steffen Weinstock <79531202+stewsk@users.noreply.github.com> Date: Fri, 24 Jan 2025 15:53:05 +0100 Subject: [PATCH 1/4] Switch on new parser 1) add a view that fails with new parser --- db/schema.cds | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/db/schema.cds b/db/schema.cds index ee6ab76c..cc74ab63 100644 --- a/db/schema.cds +++ b/db/schema.cds @@ -24,6 +24,12 @@ entity Travel : managed { to_Booking : Composition of many Booking on to_Booking.to_Travel = $self; }; +entity V as select from Travel { + TravelID, + number > 0 as positive +} + + annotate Travel with @Capabilities.FilterRestrictions.FilterExpressionRestrictions: [ { Property: 'BeginDate', AllowedExpressions : 'SingleRange' }, { Property: 'EndDate', AllowedExpressions : 'SingleRange' } From 4bea8645915e01a158031bd49b0095e1b3c301b9 Mon Sep 17 00:00:00 2001 From: Steffen Weinstock <79531202+stewsk@users.noreply.github.com> Date: Fri, 24 Jan 2025 15:55:38 +0100 Subject: [PATCH 2/4] ref should be ok --- db/schema.cds | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/schema.cds b/db/schema.cds index cc74ab63..c25d3b26 100644 --- a/db/schema.cds +++ b/db/schema.cds @@ -26,7 +26,7 @@ entity Travel : managed { entity V as select from Travel { TravelID, - number > 0 as positive + BookingFee > 0 as positive } From 4decbb75a9a9da8b0c244cc4f02a78b5dc3f89c4 Mon Sep 17 00:00:00 2001 From: Steffen Weinstock <79531202+stewsk@users.noreply.github.com> Date: Fri, 24 Jan 2025 15:57:45 +0100 Subject: [PATCH 3/4] add config for new parser to package.json --- package.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package.json b/package.json index 842eea74..d1aaf216 100644 --- a/package.json +++ b/package.json @@ -44,6 +44,9 @@ "typescript-eslint": "^8.12.2" }, "cds": { + "cdsc": { + "newParser": true + }, "requires": { "db": { "kind": "sql" From c005469de45519fa7cc5dc112a1532f5b793f8ae Mon Sep 17 00:00:00 2001 From: Steffen Weinstock <79531202+stewsk@users.noreply.github.com> Date: Fri, 24 Jan 2025 16:01:45 +0100 Subject: [PATCH 4/4] Remove the test view --- db/schema.cds | 6 ------ 1 file changed, 6 deletions(-) diff --git a/db/schema.cds b/db/schema.cds index c25d3b26..ee6ab76c 100644 --- a/db/schema.cds +++ b/db/schema.cds @@ -24,12 +24,6 @@ entity Travel : managed { to_Booking : Composition of many Booking on to_Booking.to_Travel = $self; }; -entity V as select from Travel { - TravelID, - BookingFee > 0 as positive -} - - annotate Travel with @Capabilities.FilterRestrictions.FilterExpressionRestrictions: [ { Property: 'BeginDate', AllowedExpressions : 'SingleRange' }, { Property: 'EndDate', AllowedExpressions : 'SingleRange' }