From c8adf70afea72c97b2fee3027abbfb933669cbd5 Mon Sep 17 00:00:00 2001 From: Janik Koeppel Date: Fri, 24 Jan 2025 10:47:13 +0100 Subject: [PATCH] refactor(exercises): remove TS based todo comments --- exercises/ex04/sample.p13n/webapp/control/P13nTable.ts | 4 ---- exercises/ex06/sample.p13n/webapp/control/P13nTable.ts | 1 - exercises/ex09/sample.p13n/webapp/control/P13nTable.ts | 1 - 3 files changed, 6 deletions(-) diff --git a/exercises/ex04/sample.p13n/webapp/control/P13nTable.ts b/exercises/ex04/sample.p13n/webapp/control/P13nTable.ts index cc53ca4..0e59b13 100644 --- a/exercises/ex04/sample.p13n/webapp/control/P13nTable.ts +++ b/exercises/ex04/sample.p13n/webapp/control/P13nTable.ts @@ -1,7 +1,6 @@ import Table, { $TableSettings } from "sap/m/Table" import Engine, { State } from "sap/m/p13n/Engine" import SelectionController from "sap/m/p13n/SelectionController" -// @ts-ignore TODO: FIX export of MetadataObject type import MetadataHelper, { MetadataObject } from "sap/m/p13n/MetadataHelper" import Column from "sap/m/Column" import Text from "sap/m/Text" @@ -24,7 +23,6 @@ export default class P13nTable extends Table { constructor(id?: string, settings?: $TableSettings) { super(id, settings) - // @ts-ignore TODO: FIX static method declaration this.engine = Engine.getInstance() this.initialized = new Promise((resolve: () => void): void => { this.attachEventOnce("updateFinished", (): void => { @@ -47,13 +45,11 @@ export default class P13nTable extends Table { } }) - // @ts-ignore TODO: FIX constructor this.helper = new MetadataHelper(columnsMetadata) this.engine.register(this, { helper: this.helper, controller: { - // @ts-ignore TODO: FIX constructor Columns: new SelectionController({ control: this, targetAggregation: "columns", diff --git a/exercises/ex06/sample.p13n/webapp/control/P13nTable.ts b/exercises/ex06/sample.p13n/webapp/control/P13nTable.ts index 5b263b8..ad314d6 100644 --- a/exercises/ex06/sample.p13n/webapp/control/P13nTable.ts +++ b/exercises/ex06/sample.p13n/webapp/control/P13nTable.ts @@ -33,7 +33,6 @@ export default class P13nTable extends Table { constructor(id?: string, settings?: $TableSettings) { super(id, settings) - // @ts-ignore TODO: FIX static method declaration this.engine = Engine.getInstance() this.initialized = new Promise((resolve: () => void): void => { this.attachEventOnce("updateFinished", (): void => { diff --git a/exercises/ex09/sample.p13n/webapp/control/P13nTable.ts b/exercises/ex09/sample.p13n/webapp/control/P13nTable.ts index 6f6eb14..3a02167 100644 --- a/exercises/ex09/sample.p13n/webapp/control/P13nTable.ts +++ b/exercises/ex09/sample.p13n/webapp/control/P13nTable.ts @@ -33,7 +33,6 @@ export default class P13nTable extends Table { constructor(id?: string, settings?: $TableSettings) { super(id, settings) - // @ts-ignore TODO: FIX static method declaration this.engine = Engine.getInstance() this.initialized = new Promise((resolve: () => void): void => { this.attachEventOnce("updateFinished", (): void => {