Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Test Coverage Subaccount #83

Open
sdischer-sap opened this issue Dec 18, 2024 · 0 comments
Open

[Task] Test Coverage Subaccount #83

sdischer-sap opened this issue Dec 18, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sdischer-sap
Copy link
Member

Context
The Subaccount was one of the first resources we added. We learned a lot since then. It could use some refactoring as well as Upgrading Test Coverage before we actually promote it to new api versions.

Scope
As a first step we should fully cover the controller with unittests.
Currently there is still tests missing for:

  • Connect()
  • Delete()

Stretch Goals
The implementation isn't separated into Controller and Client, which makes it harder to maintain. Eventually we should invest into refactoring here. This can be picked up as part of this task or created as follow up.

@sdischer-sap sdischer-sap added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant