Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] initialAdmins in BTP Subaccount #91

Open
marinho opened this issue Dec 27, 2024 · 0 comments
Open

[FEATURE] initialAdmins in BTP Subaccount #91

marinho opened this issue Dec 27, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@marinho
Copy link

marinho commented Dec 27, 2024

Is your feature request related to a problem? Please describe.

The initial problem and possible solutions were started to be discussed internally.

As the BTP provider doesn't support changes on subaccountAdmins on existing resources, once a Subaccount has been created with a certain list of users in subaccountAdmins, in case it changes, it will not only refuse to update the admins, but will as well refuse any other change of other attributes in that resource, which will block any updates on older Subaccounts.

Describe the solution you'd like

By renaming attribute subaccountAdmins with initialAdmins (I assume by deprecating one and introducing the other as a new one), the communication becomes clear that future updates of the Subaccount resource will ignore this attribute. Therefore, it's possible to allow Subaccount to be updated even if the list of admin users don't match with the initial one.

Describe alternatives you've considered

Another possibility would be just to turn the validation for subaccountAdmins into a warning, without blocking updates.

Additional context

Not additional context.

@sdischer-sap sdischer-sap added the enhancement New feature or request label Jan 6, 2025
@sdischer-sap sdischer-sap changed the title [FEATURE] initialAdmins in BTP Subaccount [FEATURE] initialAdmins in BTP Subaccount Jan 6, 2025
@sdischer-sap sdischer-sap added this to the v1.2.0 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants