Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Proper name handling for KymaEnvironment #95

Open
sdischer-sap opened this issue Jan 10, 2025 · 0 comments
Open

[FEATURE] Proper name handling for KymaEnvironment #95

sdischer-sap opened this issue Jan 10, 2025 · 0 comments
Labels
enhancement New feature or request priority/medium

Comments

@sdischer-sap
Copy link
Member

Is your feature request related to a problem? Please describe.
We found in an internal support issue, that the way IDs are managed for KymaEnvironemnt leads to a problem when the instance gets manually updated in the BTP cockpit. In this case the label that is being used to link the k8s resource to the external one gets flashed and thus the resource would no longer be reconciled.

Describe the solution you'd like
I can not really tell why this has been implemented like that initially, but I do not see anything that would prevent us from properly using a GUID as external-name annotation for the connection. It should be the default approach to any crossplane instance. I suggest to implement it like that but of course ensure the backwards compatibility here.

Describe alternatives you've considered
There might be other identifiers that can be used, but we need to have something in the k8s resource for identification and not vice versa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/medium
Projects
Status: No status
Development

No branches or pull requests

1 participant