From c60e464eee21bcf73dbce51cfff3ae107e95c039 Mon Sep 17 00:00:00 2001 From: Denis Severin Date: Wed, 1 Nov 2023 10:46:17 +0200 Subject: [PATCH] fix(styles): pr comments [ci visual] --- .../styles/src/mixins/list/_list-message-view.scss | 11 ++++------- .../src/mixins/list/_list-navigation-indication.scss | 2 +- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/styles/src/mixins/list/_list-message-view.scss b/packages/styles/src/mixins/list/_list-message-view.scss index 817c458c1b..52fa798110 100644 --- a/packages/styles/src/mixins/list/_list-message-view.scss +++ b/packages/styles/src/mixins/list/_list-message-view.scss @@ -2,11 +2,13 @@ .#{$block} { &--message-view { - --faListNavigationIndicatorFontSize: 0.75rem; + --fdListNavigationIndicatorFontSize: 0.75rem; --fdList_Item_Height: calc(2.75rem + var(--sapList_BorderWidth)); --fdList_Message_View_Item_Byline_Height: calc(3.325rem + var(--sapList_BorderWidth)); --fdList_Message_View_Title_Size: var(--sapFontHeader5Size); .#{$block}__item { + height: auto; + &--byline { --fdList_Item_Height: var(--fdList_Message_View_Item_Byline_Height); } @@ -41,13 +43,8 @@ @include fd-ellipsis(); } - .fd-list__item { - height: auto; - } - .#{$block}__link { - padding-top: 0.5rem; - padding-bottom: 0.5rem; + @include fd-set-paddings-y-equal(0.5rem); @include fd-active() { .#{$block}__title, .#{$block}__subtitle, .fd-object-status .fd-object-status__icon { diff --git a/packages/styles/src/mixins/list/_list-navigation-indication.scss b/packages/styles/src/mixins/list/_list-navigation-indication.scss index b34e6e02a9..f556338567 100644 --- a/packages/styles/src/mixins/list/_list-navigation-indication.scss +++ b/packages/styles/src/mixins/list/_list-navigation-indication.scss @@ -33,7 +33,7 @@ $fd-list-navigation-indicator-width: 2.5rem !default; font-family: "SAP-icons"; content: '\e1ed'; color: var(--sapContent_NonInteractiveIconColor); - font-size: var(--faListNavigationIndicatorFontSize, var(--sapFontLargeSize)); + font-size: var(--fdListNavigationIndicatorFontSize, var(--sapFontLargeSize)); text-decoration: none; text-transform: none; }