You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The current implementation of the 'Dynamic Header' does not support the behaviour or aesthetics envisioned by the Fiori Design System. Several developers have been facing issues in achieving our design proposal where the 'Dynamic Header' counts with an 'Avatar' and a 'Message Strip,' while fd-dynamic-page-subheader [collapsed]="true" [collapsible]="false".
Is this issue related to a specific component?
fd-dynamic-page-header and fd-dynamic-page-subheader
Dynamic Page with Facets Stackblitz: https://stackblitz.com/run?file=package.json
What browser are you working in?
Microsoft Edge
What version of Fundamental Library Styles are you using?
Latest, v0.48.4
What offering/product do you work on? Any pressing ship or release dates we should be aware of?
Commerce Cloud - SaaS Tooling / Extensibility
What front-end framework are you implementing in, e.g., Angular, React, etc.?
Angular
Describe the solution you'd like
To achieve the proposed design, we request the following:
(1) Add an extra div container to the fd-dynamic-page-header immediately below div class="fd-dynamic-page__main-container". So, the developers can place the fd-message-strip at the 'Dynamic Header' without interfering with the fd-dynamic-page-subheader collapse functionality. Or have the fd-avatar as a facet directly at the fd-dynamic-page-header.
(2) Improve margins and paddings according to the following specifications.
Describe alternatives you've considered
The developers have unsuccessfully tried several different tricks with the code to achieve the desired result, including:
(1) Placing the 'Message Strip' inside the 'Subtitle'
Additional context
The additional request regarding the margins and paddings review is due to the 2rem (32px) between 'Avatar' and 'Page Title' at the current implementation. The VD specifications suggest the padding between those components should be 1rem (16px) when the 'Dynamic Header' is collapsed (at the header) and 2rem (32px) when expanded (at the sub-header).
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
The current implementation of the 'Dynamic Header' does not support the behaviour or aesthetics envisioned by the Fiori Design System. Several developers have been facing issues in achieving our design proposal where the 'Dynamic Header' counts with an 'Avatar' and a 'Message Strip,' while fd-dynamic-page-subheader [collapsed]="true" [collapsible]="false".
Describe the solution you'd like
To achieve the proposed design, we request the following:
(1) Add an extra div container to the fd-dynamic-page-header immediately below div class="fd-dynamic-page__main-container". So, the developers can place the fd-message-strip at the 'Dynamic Header' without interfering with the fd-dynamic-page-subheader collapse functionality. Or have the fd-avatar as a facet directly at the fd-dynamic-page-header.
(2) Improve margins and paddings according to the following specifications.
Describe alternatives you've considered
The developers have unsuccessfully tried several different tricks with the code to achieve the desired result, including:
(1) Placing the 'Message Strip' inside the 'Subtitle'
<ng-container *fdDynamicPageHeaderSubtitle="let collapsed">
Subtitle {{ collapsed ? 'collapsed' : 'expanded' }}
Additional context
The additional request regarding the margins and paddings review is due to the 2rem (32px) between 'Avatar' and 'Page Title' at the current implementation. The VD specifications suggest the padding between those components should be 1rem (16px) when the 'Dynamic Header' is collapsed (at the header) and 2rem (32px) when expanded (at the sub-header).
The text was updated successfully, but these errors were encountered: