From 658be068018f3910e6ad23d5ee8eae407badad92 Mon Sep 17 00:00:00 2001 From: Max Reichmann Date: Tue, 4 Feb 2025 10:31:25 +0100 Subject: [PATCH] fix: Fix testing leftovers --- src/linter/binding/BindingLinter.ts | 4 +--- .../NoGlobals/FormatterGlobalBindingString.js | 2 +- .../linter/rules/snapshots/NoGlobals.ts.md | 9 ++++----- .../linter/rules/snapshots/NoGlobals.ts.snap | Bin 3779 -> 3691 bytes 4 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/linter/binding/BindingLinter.ts b/src/linter/binding/BindingLinter.ts index 50dd44a3a..95ac9e2dc 100644 --- a/src/linter/binding/BindingLinter.ts +++ b/src/linter/binding/BindingLinter.ts @@ -143,9 +143,7 @@ export default class BindingLinter { } } catch (err) { const message = err instanceof Error ? err.message : String(err); - if (err instanceof Error) { - this.#context.addLintingMessage(this.#resourcePath, MESSAGE.PARSING_ERROR, {message}, position); - } + this.#context.addLintingMessage(this.#resourcePath, MESSAGE.PARSING_ERROR, {message}, position); } } diff --git a/test/fixtures/linter/rules/NoGlobals/FormatterGlobalBindingString.js b/test/fixtures/linter/rules/NoGlobals/FormatterGlobalBindingString.js index c4ba4048f..b90dbd68d 100644 --- a/test/fixtures/linter/rules/NoGlobals/FormatterGlobalBindingString.js +++ b/test/fixtures/linter/rules/NoGlobals/FormatterGlobalBindingString.js @@ -12,7 +12,7 @@ sap.ui.define( // Although the formatter property does not look like a global notation, // it should still be detected if it is a string: const input2 = new Input({ - value: "{ path: 'invoice>Status', formatter: formatter.statusText }" + value: "{ path: 'invoice>Status', formatter: 'formatter.statusText' }" }); } ); diff --git a/test/lib/linter/rules/snapshots/NoGlobals.ts.md b/test/lib/linter/rules/snapshots/NoGlobals.ts.md index c32439133..34fb13d50 100644 --- a/test/lib/linter/rules/snapshots/NoGlobals.ts.md +++ b/test/lib/linter/rules/snapshots/NoGlobals.ts.md @@ -36,7 +36,7 @@ Generated by [AVA](https://avajs.dev). { coverageInfo: [], errorCount: 3, - fatalErrorCount: 1, + fatalErrorCount: 0, filePath: 'FormatterGlobalBindingString.js', messages: [ { @@ -57,11 +57,10 @@ Generated by [AVA](https://avajs.dev). }, { column: 11, - fatal: true, line: 15, - message: 'Expected \'a\' instead of \'o\'', - messageDetails: 'Check the source file for syntax errors', - ruleId: 'parsing-error', + message: 'Access of global variable \'formatter\' (formatter.statusText)', + messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)', + ruleId: 'no-globals', severity: 2, }, ], diff --git a/test/lib/linter/rules/snapshots/NoGlobals.ts.snap b/test/lib/linter/rules/snapshots/NoGlobals.ts.snap index f682c521cd992a5a5aecc4f1190bc3b5df256b8f..38ef0dffaf14d07ee5089bb93ac864bdd29db462 100644 GIT binary patch literal 3691 zcmV-x4wUghRzVgBMQqw1Ijh|H$cI>RBS-O(8rVQJ9^o3+n zv6Z_6dVmPdKM@tuR$wR4F2Zdhbl5bNSt0VPmX;PoJwhNFggBTtikt%;1}*}B4Ezf) zAmEV5eNi}jd?6KnKV@5TVN%gosVIW#)7gBy-y=t0< zdDO`0w!10lxH9h(Efb2Zq;B$j49};c6Ix0gSL~_$h7CTjxnBO#9518Os%0sYs^$6S z#&e3PYx?B;gGcA#8JLG>R7fufcuC9$J-9IFpBH)1zc1ho0j&~jmEdC%tP8*`0T1Y* zg+QO@bU0z8GShkv((RtT!IY+}xqV*CNDhYl-!~sKWZkgkjHSw!ZEE_YB~KWpJT#HV zcSxR5QW@2fHC;ZT%qVvxOf7B8ik_73oK36QKVzQ5H0KU;Otlp)W#u9=XH-+OXLATj<%aAXE_@4yY~&Nya>xcM8nOl0DjKrEmj!%Iz^elO%rA5UF8F_w z4c!JI>Lv1w+~h1Jmy!z-JSM@55`4)C>Hz#80BeJ#13D@q`-1R}Alw^-^Feq$2rq@; z>miS6xXAQBL-6AebcA7h7(Nn)TO)8j;xUaZF^x1_K^i%EIFV2-OExCtNtaxCMlm%d zo>JwZj5anT4?E#}PDwpvPnkw$aw;}$B-K=`kY!?)t=JjsPW8O)4dR7!iFA=UsmpUv zOSTPJ$+~p<_?SFxBs0!d!;}w?AGcz1b@NcYZfwhX?7g&$lFt?LR#)Tgn&hp;hqr?z zc$-tXhig2QS={A9aX;l;;KvkOany|!o6*#BvGdcZ1$6im6)Eby0>;WM>SwC0!@C!O z%k|E#l>Yuz0iP;Qf4^MN->(b!o`C58mF!ItJR-r706cW1`rDgi=LWLm6UaA|2xLo1 z56Qz$Y-F@t-nD1bYV5dftCOl(i{l02cxaJ0e!x+iHdz~#aocl_n<~sR{6^iP>ivlhQ_<~<#OD^tzQjq6wi>y44ipZD*H%M@|1Q`kb zRf3lT@C~0JkBZ0}0eCY2T|w9xgx?6lLVm0Xd~!uo{}+LO2DS(|T5jr}SZ?a~ z=JaJ|{>|lq=lc4A%2a?wlYXA*J>@Wcmtr~_OB4Q?iV(hCz=?7RpRO|D+m?i(>+<7O z;(g0vycZl?{4PzbZ0j{o_0?&;t`OC}uvN14>dS85;_RMVSgHSJMU;AvfL-NMdRMiT zdgp>*xxSf|66hBNIFG(wDNmsPenFuB@UlR6o_y_;U|fQf1g}Z(=>UAyU!Z?C*I#c6 z!j>RB7livl@K_}UdZ?!Hu3drNTqAE42=vV*5`1Zy_H0FJw=Cd5xrzS1D%bAyB{6ed zoUKyf-c*9u5)Z>e7b;S|Hwf5YF01!eyL|VSfXwyqe5Hzbes<;a!E*Ej9 zfbWywE(uHt{z`(U1MsSU5&x$Ed^-R?3qVg0>>%t7!Go17;@$~{S{Hs*mg`83rmI?* zxB4dV(&hPLMauJL0q-m~kteELo(IZ6&UN&WDi!H%B{(jtRrY*ENFEY!xLlHxRVH~; zIncSDUZ@hw8wxDnV%&5-JK=azi{Ir=ZZ61clU5NGwobtAa(R8vvQ?P3#w?TAu7%NZ zowF(=z#^X&@H+w=W%U&S-w^PcfPeE7WMLQo|0)Qw*yX82EjN|eAcQlGD6#{L-*%Qk zcj*ioJH3pkh@1|916iVLvT+Ro(%hrE&f&* zem4w%8;1V~!xIsxkHW!d>9NJAh};{6coZ%~;rS>WsDoGQ;NR;!rqLqPhI(kLhtYa? zcRhT!9;O=LxdxAEU6JV@HNck|;9Cvwb_0B(5xSe;c$3Gpeu+YL!xbo?bC(rRR(`m` z$LU36bZtUYlcUEJTfJS;Csk*5FT3re7B>}hHdffR#g#Z}?#h?rvvMl?k)m(QZ67Lc zy!*^}N>waX)~20rmhCAu@1+gl4axQXMG4Q`Cp2N6O;KsURh|D(tTDRSsX9u3*gK{fqLI zFidsSo=&GmkKKCeux*=KJYzeAIXm)fIs0RC_xm&Ee((Qhx`s>8<-JL)(Y31S@=h|> z=&CwhgC*!{tkHE<=_-DKY=PU32TIa_Z%B-VJ%Zyazls0K9wi9)^ z#9|xrc=kZ2ay`_NjnVDf_wL%8+>_W5-?wLXGO)hqm5bmKHgm}PNHn_`YoMofC{Bvj7 z}foQ?gcSH-G z&PEHKej%FmG%7+rh{BJe&{+q&>flyyGbiZn$b{aiga4_64fSxS9`3I9YgmQetcRc1 zLtg_NY=AS~zE4r3Dimmhx<=U22sbxEqS3EG6$&>&V-sv`f)hq_N24;2Jox2I6br!WwvfjmM;^$mCc%oM?x$?eO7tc(L7M(p+S6vIB1K z0J8(0?tssBcuZP~OipydcqgPg;i*oz)afy4EiyUO1xLFe(FKoo!LN0BOxlV}Zs>-? z-Jo>CBi(SZ+hek(sJD1%EgW47%364MEqrY)Jke%b@w>)`%% zu(20T^mV-?a@bg~y)9c`S*Lh64icIU*L+g5ot%noq;hFVtx)0vp z=P~UrGW}#9yx0d{?t^dj!Tt^K-y2|1_L#0MGQCNLcgvv3@Ie_~m*J(2@b!%z)1KnD zxxXD9e|4i@ah2k{Q$%^!4EgVx8K8-yGo*03zj=)fJk6zmAsHuhQe3*4>Bx&hvO(NzJ}bmF+3blBZRB%1FuyC6$unYC>@y;yZVE&LDsz zakZqX+m4hq<$hCrZ$>lKJ7)Dnzw^^3{mwTy((}exM!PXKXZP@y{(d=OWKv1@J~pn( zN!3=(X-!v?6-L7Q%PvK2<`n=UsZMCRx)280JrzEEuk{kTw$iVx#Dy@WrqZhUu8f|r zHABzhkjPkeETzR`^LJJe3ZF?<=>rvsiQG8N)eDAF5cvEig7lG!KyXgelg7Dw94Pwl zTRmX-yn0xn9GL|pwyG|RHXkIOtOyd>*594Ee7SniSmT4nW0k3$MtXI@&|a1BNGqnQ z+p7zS4j&{wRGGq|rY2Sw4qa8j!Jbl9+4bO^J}G+mvvM$GAvk+mMm1+$5OUkAc=q0z z4)57pD{%Ifor&k7K+_F9=KNj7Q}%YpD?#|Ydx&f;SS7a*BR*mO=t_kB+|$2Y1D1q9 z>8Cy3Cpt@c+7l~lXns0&BxBo#UYnC&+H-cV&{)b?#87$6)F@dRC0B48Eq0gthRK{_ zUgKxw`0@MQ!(m^3vbU%;PF9W+zh61>e=BRzwn2@im7~e04&xe+M$5|4;@6ZNIc>R3r{v|q-NWO@^OVf(t(G~H+dXFl*meNUeXKMf z&Lr(+7o7h=#SfR_-*_vGiIyIC7f)8?wez(Cc9uI+d%DW6op&yXmFwDjukw55{|mWK J&egzb002g3PdESo literal 3779 zcmV;!4m|NeRzVY`-HQXCz&BSo_1 zLykO-j|H$KR|a>H-32A4b!=zqw60>uYcJ76UF@}VnW&m>;&3Hq)mhmS(Z8@#O$i2r3F!s5QqjL4$K-w&jAkr7lA(m z{skBia8TsmD3UwBkP6Gz)>cFlB7$fZ;ywXug^UQdiN>Tkty$`XcFY(z5iPU}X?Cw( zvnTpv`Vl|f{#nEUWS`w zAL!wQK%eJyBx$CzQ$`-r?Y`YmS~s-(p5HQ>hhg^b8;_cbVLD3I))d>ZbYsF+#!X8Z z9G}H^P?=WKSw{@dw1;I>c`2-rnO_K**`n7hMmo1Ov}+yBWgw; z$+|xJziPHNty#J=lSfc0H)L<~;9D?cqgz%yWM2U`33ykzA*(JsWaY9#wkWd8joAWj zo|_L;C}u;K1pK~$FA8`mD0XEJ{cq%Aw?T*oiCIc+aF>$D$s-b6kl=F?yd=R68U9;_ z-cad?j)~~O5F81C8iEHx@M;KN2*bC+KGTTbH1>KJ-VQ@|1jZt8O9Va|fq#lXBg#HIdeo!K^+us0_I=eNIi^?@U@|c49I(`*!WTSi0dI42@p(3idN5ELQCH73URdLrMaCzQ2l~Ti> z67cKgso~ER)bJ|;zAqpq!6peFl;E%o_g|?R_Gi1fQ6mLJ&9x;mp{-^Hl_58oWc7Rk zbY?PI{Fvcr6Pi^^d<(?!;39E+uPgmdS+38{%z}zJ{CgD%=Y9bP$_?jxmmSXj@7XfL zxvw;8o|C^&p{SOh6X0s*F9b!ll5ctps;Ukd@$HU9l{~Hv@t^ zCZey&@P-VXA=nv$-wMHa7(NytkOT8W{S_#sTT17Lg)>7gYm8>~QEzY5-5afCjb+K) zQslMP$Xf*|f3%#Gf0H($I{LJ>VCom2UeVP5CE%ZdtpbjeoBGF>oBI7ZeVLhmOL^dV zzJ9ne6=2b%Kg;x-n$57w{LNF&n>Lff4d?|y<5Ppaw)x|+Dg4+L9jgEtV#*= zivrvmQO}nr(Eqp~(0_DUpu6{>c1mzcg0uuLOYj>qd@Wd@zbeBIWoQb))(|`$g1f`; zkxB~ma82X=>OW;7iN2rz%pr6#@IpP4stHxpw!K#LRPXrb>l-Qwd&6 z+?ozQRFU$%LBPIpS$%)C%Xd!+$UG0vSE`85PLh1SydwUkLJ|M*S(vB#)Re$(dCYv&=Zzw&BO~^TRn-R<-hq#Vn#{lUQ+aK`Qv2{aGg1o)>K2W2cTUydd&&(YU%PA_|m{4>_nbuX$Y}TKgxqsH%r+nHCb3~uY zr1hlkte{dID8W-KfTst`;>oQbCAcbV*Z3-juT57lX7Qm#`AV9WHtI}e(xXRjK6%J- zEIpBRT*BOqS+?B$_}u+q#=Q6ad8TWq1YQ1%#2Q_znlArHagDC3)3vz-U5z!m-ch=W zALm-&vg6*8SK)HH_5`Nb5CGfHz!R9Ckl-pAPF(5Cxxb^m6mj~Vqguw&lByewY9Z7$ zBRi#JY%QBI7t^dq)U;-#RO_fZ<7(3~BUL@APgttsMqNI!IHqzcccPQ|9%{+P==SY< zckNB>N$yBovuAfIxl2v#-KmX_?b)+q$L@VQlDh*Mqiu#clKWgE`Ic>&0h^r@ues+3 z7jC6o-CdF3Y!xtEZg8Glc5wQu!7_uhaV|!lOP7`(iK6vw;WadHAA{_aU}HXj_PP&k zNN`euGZG{vFeI3f;Fl!$m;_Htlnmvj&q(mR1b-yKmnHbR1b;8V_ayj%1V5HQatBRh zSSQ1PJpT>b{dBhE`Z4lsXGWC^otaO_h0e@Z$czSEJ;OS%0f~S8KEqE%&3ZA|zR`7HtR`B!-v7Dzd5&mHeUXMXX z9qg)uoBhq4kiR1nezOk#uMRfU!@+vEvp%R{6@H^0ep(NG4RD|V&iMO2MUASk+z54z zu(c6xY=mTEP=hKQX@bTk*wzHcn_%4EA}VT3h1;8^CJjXL8~&u*XS%k?^dGw63^&$Avt?<3AKGVJ;Q!xzD zVc0wjhlb(8Fnnzo-W>LsZYa_nA-^JU1?7Zk%`77N=j&Jh?p*ykT3WwKk8;}ZZu-0T z;|(=E^Fd8%r6kpKT1jY0)xC-DUg5ce0ItN*87cy7-*!p{@P>O47`xQ{HuKLQ_(jqghkBp`|K}g#UL|irUO8 z07Oa~*9~nU401aa{`h|DC3J12UtNhW!lahYXx0r`BkAa-k;5UGwVilcPsHbMRuPJT zNml8@6^V)bIL$j345c6l_yGdxqZNVRoNlDdb9cE=^xwUDzzBHsutGU92S$8VeJ$Do zka(;jNaR|7x99Wa>Oo^o02&{uOzku?s|$wqs)R>IwKT(7T}Z4AK;oAxQ#iEr`0B!; zvnn_^lj9u`jp^Eqr}lBWdMG3TPOV zLDC`@|22|Uj-;NNURZUU^agOUy#yz@X3?NBl+U2{f&9T(vI%Sr>{PSRd>!TtYCf^aGRjkm&> tXz77>@mNJ3J6|VYXSp-Ar>p$fdB=iSd9Hon9e&RI{{ivbF*{Cb007h^ci#X2