From be38fa1e02fa690df7fdce42545d47fe4d2c1d36 Mon Sep 17 00:00:00 2001 From: Yavor Ivanov Date: Thu, 6 Feb 2025 14:58:08 +0200 Subject: [PATCH] test: Stabilize tests --- test/lib/linter/xmlInJs/_helper.ts | 7 +- .../linter/xmlInJs/snapshots/transpiler.ts.md | 82 +++++++++--------- .../xmlInJs/snapshots/transpiler.ts.snap | Bin 2265 -> 2266 bytes 3 files changed, 47 insertions(+), 42 deletions(-) diff --git a/test/lib/linter/xmlInJs/_helper.ts b/test/lib/linter/xmlInJs/_helper.ts index ce34922de..288f7076b 100644 --- a/test/lib/linter/xmlInJs/_helper.ts +++ b/test/lib/linter/xmlInJs/_helper.ts @@ -51,8 +51,13 @@ export function createTestsForFixtures(fixturesPath: string) { coverage: true, details: true, }); + extractedResource?.forEach((resource) => t.snapshot(resource.xmlSnippet)); - resources.forEach((res) => t.snapshot(res)); + resources.forEach((res) => { + res.messages.sort( + (a, b) => (a.line! - b.line!) + (a.column! - b.column!)); + t.snapshot(res); + }); }); } } catch (err) { diff --git a/test/lib/linter/xmlInJs/snapshots/transpiler.ts.md b/test/lib/linter/xmlInJs/snapshots/transpiler.ts.md index d7e8c52f4..20dbcb7a8 100644 --- a/test/lib/linter/xmlInJs/snapshots/transpiler.ts.md +++ b/test/lib/linter/xmlInJs/snapshots/transpiler.ts.md @@ -86,6 +86,14 @@ Generated by [AVA](https://avajs.dev). ruleId: 'no-deprecated-api', severity: 2, }, + { + column: 19, + line: 2, + message: 'Access of global variable \'sap\' (sap.ui.fragment)', + messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)', + ruleId: 'no-globals', + severity: 2, + }, { column: 12, line: 15, @@ -103,9 +111,9 @@ Generated by [AVA](https://avajs.dev). severity: 2, }, { - column: 19, - line: 2, - message: 'Access of global variable \'sap\' (sap.ui.fragment)', + column: 20, + line: 11, + message: 'Access of global variable \'sap\' (sap.ui.xmlfragment)', messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)', ruleId: 'no-globals', severity: 2, @@ -118,14 +126,6 @@ Generated by [AVA](https://avajs.dev). ruleId: 'no-deprecated-api', severity: 2, }, - { - column: 20, - line: 11, - message: 'Access of global variable \'sap\' (sap.ui.xmlfragment)', - messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)', - ruleId: 'no-globals', - severity: 2, - }, ], warningCount: 0, } @@ -192,19 +192,11 @@ Generated by [AVA](https://avajs.dev). filePath: 'resources/namespace/SapUIView.js', messages: [ { - column: 13, - line: 23, - message: 'Use of deprecated property \'tap\' of class \'Button\'', - messageDetails: '(since 1.20) - replaced by `press` event', - ruleId: 'no-deprecated-api', - severity: 2, - }, - { - column: 13, - line: 35, - message: 'Use of deprecated property \'tap\' of class \'Button\'', - messageDetails: '(since 1.20) - replaced by `press` event', - ruleId: 'no-deprecated-api', + column: 16, + line: 2, + message: 'Access of global variable \'sap\' (sap.ui.view)', + messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)', + ruleId: 'no-globals', severity: 2, }, { @@ -225,22 +217,13 @@ Generated by [AVA](https://avajs.dev). severity: 2, }, { - column: 16, - line: 2, - message: 'Access of global variable \'sap\' (sap.ui.view)', + column: 2, + line: 28, + message: 'Access of global variable \'sap\' (sap.ui.xmlview)', messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)', ruleId: 'no-globals', severity: 2, }, - { - column: 24, - line: 15, - message: 'Call to deprecated function \'view\' (sap.ui.view)', - messageDetails: `(since 1.56) - Use View.extend (https://ui5.sap.com/1.120/#/api/sap.ui.core.mvc.View%23methods/sap.ui.core.mvc.View.extend) to define the view class␊ - and View.create (https://ui5.sap.com/1.120/#/api/sap.ui.core.mvc.View) to create view instances`, - ruleId: 'no-deprecated-api', - severity: 2, - }, { column: 17, line: 15, @@ -249,6 +232,14 @@ Generated by [AVA](https://avajs.dev). ruleId: 'no-globals', severity: 2, }, + { + column: 13, + line: 23, + message: 'Use of deprecated property \'tap\' of class \'Button\'', + messageDetails: '(since 1.20) - replaced by `press` event', + ruleId: 'no-deprecated-api', + severity: 2, + }, { column: 9, line: 28, @@ -258,11 +249,20 @@ Generated by [AVA](https://avajs.dev). severity: 2, }, { - column: 2, - line: 28, - message: 'Access of global variable \'sap\' (sap.ui.xmlview)', - messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)', - ruleId: 'no-globals', + column: 24, + line: 15, + message: 'Call to deprecated function \'view\' (sap.ui.view)', + messageDetails: `(since 1.56) - Use View.extend (https://ui5.sap.com/1.120/#/api/sap.ui.core.mvc.View%23methods/sap.ui.core.mvc.View.extend) to define the view class␊ + and View.create (https://ui5.sap.com/1.120/#/api/sap.ui.core.mvc.View) to create view instances`, + ruleId: 'no-deprecated-api', + severity: 2, + }, + { + column: 13, + line: 35, + message: 'Use of deprecated property \'tap\' of class \'Button\'', + messageDetails: '(since 1.20) - replaced by `press` event', + ruleId: 'no-deprecated-api', severity: 2, }, ], diff --git a/test/lib/linter/xmlInJs/snapshots/transpiler.ts.snap b/test/lib/linter/xmlInJs/snapshots/transpiler.ts.snap index 4a0d0a2c1af8cdb360a83c31710dff5dcd0e1e93..28e4d2e785e2d1b9ca1ab6ffe7ff024db359263a 100644 GIT binary patch literal 2266 zcmV<02qpJHRzVE_5Zu{W+k1DjUhk5oDeI@ZGxyA#`<*l2x##n}ST0(QaoRusWgeJ;#m~I$ z4v*QsYg(M%>am3iw}Yb&E9Fo5rf)OXUvvWhzKf+23)tP{4iyQAKawQs6o9<|jse(0 z;-e&fTk#Y(0zy`Y*=!bM7(@Zd5b_5ATZsx18zrji_#h+LLX_1@XDU`>e0IigJif2t z(GgxYZ8I<(TTi9VR4m)ypYxfUujCrP_lf!Si&Zl(e&i15sZ?s_P&Eh~n+D9?pUeAf zd6rw26W*ICT;?4I!sU$;;Cce=CDQVgcFSv8Ny=Dc9y0>&g;z8&r)h#_nKqB^sS&u! zpVxt#I0Rr8KpDWN0Xz=i6#!}3n^v&nA=m}726ozTYTRQBe9kUAk}Ep*JjXliRP7*g zh)6R=$}C{kEz&edvyx@g;>TIA*toFGpV?XxbL$C zF6TyiiFvkZFEl%ltV0ny=y_~e#HBtO85t26DlP$P4ZNaBYSSbgVzonre3CSPe~JK4 z6W})l_$L95DZm#L;5kJCUTX(@lhbj-v8ok2f;HVC2NKe~LE&x)ZM z4!_ zVv=dB#q?h>K#2o14$Q=X2jal5V3K-KR(`1Y3`*h%#4xHA3`*q+Y9atIyE)7YhsX;yMqn>sF z*p?1}$s{KOHhIu6xbF*C7A&X8ELvlp$%+=IW4^#^dqmFV==0yv6<*52IO0&-324>l z@{@fUIF!}jJ3lu~D^95@t~wq)czn*!(-WN2L);JOalyx?!F^hGJbHxJxFv$=)9s5v z;QIRtg{nE77akf;rLe6KIId|FruLSN()4t3V%P5JUGLtrr?`7(i5W%CC#I*T_DoL6 zOORru+s=61W0}r+2~MYM9vNhFD_}SDk-{`6y>8q=nB;9sZ%CnfM z)Qo+?6Dpb`!?6R;u`KR=kX88pT-BUru0XGGIX~-EcrKhxYR02Xl{&pk5<1YYG-3lHz_bhm%{x^aLy{zC7QGe*>>=hC_^w0els0#%6A^{#F zz!L=c9szztfafE%`cE4PAE{8ncx_eqm{=1&POk|ckFE(HFRlq6H>!2vV~CKu#IP=+ zJS2vRaQIU-T!n~sQUfv?aI*%?YQTyHoQwhY%JN35GIB8nT#5nD#DEuLz|J^uUmW;m zd_!gA=W*bdap3Q9;JO4*OaPxq0*}k`MyoRNvn23*5_lyEWKzIKQov0*@P1j|XjMi| z>42*P59q*Gbl@L4@ZBNcce1?Es*I>uJJ0Iy|$TSfqu1s=>wrb8{J-^c>r&H}&40)Nc{ zhev^jMu8uUN~Y;eN;%m+db#m#JBpggmjDyB> z{|#&H)^359h)Yw% zDvV5~g9_88pV zcP9aaba(a&%XYCrgx=s08jT_pdvYUT^<@Bhx5Dap&%&y_njVGKo7xGhO*|6%d3*25 zDp5X8fO{o%RF+s(ahB{s0z52D)Y_jIezY#5>J8cSg;iN~Yb2{CN$fTSm{)+R0$fml zugiys)fSQMgbLiP0!u1zK?PnC$ILXKBp)klRY1>cz-KhzF%9^k2D~K(@EEWn>#p&Z zWYFX=i6XGzcnz+X&xALZMYTiT%Kwd)%A#@(^LE%viKfS9*7C>1KEm{AeeXdHv12N7 zgNaT_Y%qdlH>{&(iQ9o$Hn~T0VZl2X* oRphk91MXE!o0s}5{qo_RH-G8x6EJxX{pJVkKc;y5&UiBb0KJ4ood5s; literal 2265 zcmV;~2qyPIRzVtn}juSqY|`*eKfoZ0XEzjMBCzMszJa?x^(Gya7y^1uu%e)h(b z9h_t*|r{%S*Bxx)$j~M~?!X8zOX&Inerp=>gN+fRV zPiw^04**yIPzLZ30AB;}Hvl8DHSJ=@L$ULuDfWor)VRkM`C+^4NT#H?=Q-X%r)me0 zK|~rcUSxXTaNlQ( zT;3Za%gnP)d$HAkL|qDPzvrgXQd$P3AXb|uQHq$U2GAI6`-;?Jvkh(AMduYjn4c0gUz<+-El&+~pXx!Qg&# zr{FFh;Ly~g*D1Q|A0)uX2=E{QzCeJl5a8QU@a`J%<6*>qx*qYyfXoOI3Z2d z+onF20KS?4t|owI62Kiv;Fn22Pf1e~ZBr*xz)T7_k^&Y}z?Bs6-Zb!7TAG?1=F41Wb4+U!%Y)coxX=Z_P8;%y*hPO-7*}q>c%9GUBV%U+D;H^Exp+no@Vv`d+P8! ztvIEs=yg20|M+1)M^A804{$%A$Hk|EX>gyG9giO3HExMx*45I^;gLGi0amwRJPu0^5vG2^+KbndSsxgYL4_;RmGmd zo=VNwEi9p;I5HeN@EptH-kVv4@6A@tdFBe)8r``Cr^2)0*plhH7F#(W(BR%|;8nS( zz1oVgs2Z!(jFw_7SE(6m9(O3#!hh1OTubiBH;k_rXm2M#kpSmkAo@1+(~Iw?u`Yhf z4E^-7@Y79^pC*349`N`xfMl=0W7~#-NAiCIJm@unM-=))GZ(HC>_~n5zd~Ikz{3Q1 zoB-b-!1oF869W7^qSeo>2R@P^!uZE3_?T^ik26j1@n{o#{H_T;Zc^&tBTdL#M6(W2 zJ}sJh*!-yyu0nV_p#oznuuTOPRN!+e@T>~lDC3QGGIE;++^zxd(0~;UxT*nL;=o-p z-e@Nyr{jPd2R;!8z8nYs9S4r+zytcaWJHjV%R2A_9r(2l+>!v^lmwQO>ynYrCV_{O zz?F!I+?)cQNdXxdZ?uz<*)*^t4V+8^ZW?$Z4g6*V7#ZzOMiNBdHVPC*f#aiqH41!p z6nM`V@TD(kW5BaxfHn@iZ5;ULIPivyG&S8e_09}%Gy|N@03XT#zsLX& zO#nZfkfx6GiE_Fn=o^M)qCdg54h8E^u+&hncERLh*AIc2?ONp5OupQ#GsUkS3(UWx zS=a9ndI`UT*_WRUxZP(ZU#S^6G5Pg{TPr+Ra!P*3$I-i|>&q#dHmAW7r^4*I&r{4U z)vYi*&H}zME5i3jF9_c)@B*`qwy%d5!uOd0d_U7GVCci~uMD!#gJWJZ0Kp#~%9r<{ zoEX6O!$Wx;52ajSwp7FGIA+IsIK1^-Mjbt3@SwxVeCx5J109QK{!8j)$SJ8G2h8@t z!-t2XGYemCvT(6C4u;#J^Zl)d27-6D^bYTyY=w7yu)EIauJg5|Yk|A2+>X+&*Opqb z-Ms`5=pFqemN*jHdC$hl zDv3QnfcHyuR7R|dxJ&ja0$h>?s-15PKU&AAsRlOv)hbrq9AVW2(e91`r(!@g23(8* zUzaZtD{YYNgaX{B0Luz+Q33uSu9>MoNxoLrPCzfHz(-Z!aTWNH3cOkaxCT5ZbJuv= zW>94}i3Gjqc#T*u-wAKcz)F{WE8iB7GH~oXPT66;6q{{{OGI?y5HcryS1Sbkhw