From ce27fdd60898cd764b4363c2ce4345e84e901909 Mon Sep 17 00:00:00 2001 From: Yavor Ivanov Date: Mon, 10 Feb 2025 15:46:07 +0200 Subject: [PATCH] fix: Add Fragment creation check --- src/linter/ui5Types/SourceFileLinter.ts | 1 + test/lib/linter/rules/snapshots/XMLInJs.ts.md | 13 +++++++++++-- .../linter/rules/snapshots/XMLInJs.ts.snap | Bin 1713 -> 1738 bytes 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/linter/ui5Types/SourceFileLinter.ts b/src/linter/ui5Types/SourceFileLinter.ts index 34d8f9582..6d1ccbbf6 100644 --- a/src/linter/ui5Types/SourceFileLinter.ts +++ b/src/linter/ui5Types/SourceFileLinter.ts @@ -267,6 +267,7 @@ export default class SourceFileLinter { return [ "sap/ui/core/mvc/View", "sap/ui/core/mvc/XMLView", + "sap/ui/core/Fragment", ].includes((potentialImport?.moduleSpecifier as ts.StringLiteral)?.text); } diff --git a/test/lib/linter/rules/snapshots/XMLInJs.ts.md b/test/lib/linter/rules/snapshots/XMLInJs.ts.md index be03b5deb..46b2163ec 100644 --- a/test/lib/linter/rules/snapshots/XMLInJs.ts.md +++ b/test/lib/linter/rules/snapshots/XMLInJs.ts.md @@ -11,10 +11,19 @@ Generated by [AVA](https://avajs.dev). [ { coverageInfo: [], - errorCount: 0, + errorCount: 1, fatalErrorCount: 0, filePath: 'FragmentLoad.js', - messages: [], + messages: [ + { + column: 12, + line: 7, + message: 'Use of deprecated property \'tap\' of class \'Button\'', + messageDetails: 'Deprecated test message', + ruleId: 'no-deprecated-api', + severity: 2, + }, + ], warningCount: 0, }, ] diff --git a/test/lib/linter/rules/snapshots/XMLInJs.ts.snap b/test/lib/linter/rules/snapshots/XMLInJs.ts.snap index 41f77c76d648250d28952969be9cda4a7b57d984..a05d3378a041ca898b9773135106ca0e8c511495 100644 GIT binary patch literal 1738 zcmV;*1~vIXRzV!qF%5C59XzMD*)ompmPlS@%V^iRQBt0(pc-2EX4MMaOQXvMa|DTs&^ig2J-D5BLr z1VKc^o6T;LeK%~9U8BdD{PoPt`@Hkc_j$h0`+fG!rP`7ox*v}}ds!x4;>!!S-7fObxS`*y2W<$8%2VC<0@;3MD$mR|44v!Q z#aP;5&92HuBwZ(wRl5;|4H+ft_C(?|Cenwl@5He^abGh@!eBy~ail%toJ<_gk2|+- zo!go*k#S?Ocup;ndbrrksYS20oUnGV+r3_V;NW!n|RVFz1}c;(R9^ zc4SQ9%?HAmqXMS)%9w`+W{jE)12Se*#i_Nd`TzBc@N%0GeQ9L0 zkpJ@rjS4~>)98f5O--$3KAoDGmig<{)LZ7!42W#&{bw_!v9Q-{8x8z|q50B>I7kT(s zUUAJI7OA}#sXgFxqz^vYF8JJi+I3|drzkA@;gaLqt4`!OOTM%x;uM}^vD27tdegNw z+b8z~kM;y}p&f*Y-HfF=b8IJ}?QFbvalT^L!)i0V8%Fl&h52~eJ}0GpUyA8Meh&EXpfrK5dND(r&NiM>+%Lft=P`C##R(-84_Z{IB57L*|(_21Ui z&2CBk5l^n|D5uNcJrFrPD&TE%JIB5;e=k<|}v$?DH-$?B_HvRcb*%If#DWpzP_3#qvw(Z7?L zX3P9bru7wRWGAnS<{2Fx)WOr?Ssm81a9I`4y}J8_Ec`SJuVz6r;KSF&^kW9RVC<^9 zUoqeh1{fxcn-H1sEfapbyY9vU!-BV3@IDJ3wcuP1KB0=|Ufum<4ld{5$2qu`gULL+ zmWS6DcGcaL0=%mL=L^s*z|{g|i%=={*WH#d7mM(*BCHqTOGWro5hhD;zNEModR*5_ z@Tn3!Rf6xAAU6W{kHFf9;#%x+y*L6-jld5^;N=mREW>gcE|wM7(mor7(IK?N)LwVV zRZp%RZjbxh9!q@!lRp%};?^M&_jq6VkY?*3xqBm_qav^!o!fUqXCLDCklFi>&Dap_ z?P1CNAC+9S-26Y5Tvfa8r>LCVtz+x1y89|EHxfp-4MFake_QIuusd#chPC_r)y+OX zZC}qs(n;iwjehpZfi(JK0^YvYM*o8YH~Ojq8L-hWb%E4cQ#^R5FSI8GTviUj)RsS! zo}7JKzz>yy*`4vex^Y^T@3is%*gQR}wA*}3WE&c+YVc(Zu4wQ}^&DF7Y5I~3Jd%O0 zWZ+5$3?1flNYq2L-j4in9lol=_jGtkhdZ-S&BEjA?*L{`;B_@5X@W0@Q74bpeoQphtG1h#$0g}HsZdE)q@AocS|!1& z${_J-o{a4AhVQuYbTV#xfju6k*)u!czISZg4TD4m$@t{>xb22bzuMA0OVX~&L`HQl gkkuipn0j_`(^at{@lp53n+~6U13~fAx?Cgx0AT@ega7~l literal 1713 zcmV;i22S}wRzVSUxMqw31L;^tws4E1~ z=m$X%KZsks-SfCT_B?u5mv#En>AH1p-TME}Iro3+KHHoRWB=jwGZ&-^R4C8iexHnF z;)Qp+_a@%Ll8n^-vDcV-C=JrcYo&{^N6iTueV z@m7WCS=DM4QA7wtNr?CKoa`0g6Tp+e3&3UI76FGvcOvWb{6o@L!dNp$M@JDAgoPLp z;7w-dIs4Nt~RD+mY&AGSP0RHa+EqAK2zDrx}Fu zjHedY+%%Lri+Xs&qMRj}rrv@~wVBE*UJ?b-!sdrLo8ZfBf^YMfxnZow-Rsx5JL|RP zW_wH9lDyKJuPJ#y0RBMs+Ay_K@*dnPd71yUU~g2%sk5x5>qDQgzj`IIzb@c;0Y4V- z3jr?+xGeaO+;)(+I>`S;bdWCzamb)Yho6~7$9yI;a~<!8_w7e+VE2w3w@N5=yUyB z0sc{dTZ>RD!lOm_WfA^W)Le^O#r38zvHUn}FGby`Eo-A@7(}u=W@}@1H}HD@Yjde| zV54|*XC+=x06-N`=j3eC{XQc9iFzsEwZDxH& zB~#^gZ`0o-X@_#Q(fd0V#Yfhca>Q!|dak8%Stfy6?Y^I}1AGn)z{l7IpF2b>NexVosr8j%(zS4LyJna(z~ap+d+LQ zTcIB>P2VxC;#S~K*Y0Zije33l=&|GVWA8d~V*dC$8=gNe<4Y8$WLxf}i&djN%QX48hcYEtb2Qy1iLae7X|!Kz|RG|B;dCK{v_bA#l7#4i^ikN=Pf)}lAb@ycp{%C<^!?+EJ4d1lkciZc39IzaC zs{`+M;86$87U1K$c<$HTPZi)o0e)0~R|+s$gx8Ajy3)3~yIz8Km*89p+9kMDf_xe3 z<-xk!5%ydeK30a+GJLTNe=fsh1#0O~N^aTc=PzEDMt@AeJ9gUW ze{j!@zOF#_*yvX_fz(-3y7x|B7*7efpdEtgEq^XMIs2A?7qlDmTjPD{>SGzGA|6 zO?b(Kx8s*yWw`Na=Aw?2$uvjgg{zN9 zS1ksqyCl_O+;IJ@JkCqs%Y=$rl&)HBbxK0ekdX?SflS=-R_OWiq#AdF$Q_Tf=&4P0 zuN@lq<4DO!jZcn`yMEjb8y(#1P)=T@@P=AANtk>G1hCe6WfN H=OO?A4vcsq