Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2: Added a Loader while image is generating. #9

Closed
wants to merge 0 commits into from
Closed

fix #2: Added a Loader while image is generating. #9

wants to merge 0 commits into from

Conversation

Utsav2505
Copy link

Added a Text "Generating.." while the image is generating to give a visual feedback to the user.
FIXED #2

Changes made

  • added Loader and its CSS components to the index.tsx.

  • added a loader along with its loader wrapper to the return of Home( ), that will appear when the image is generating.
  • added a timeout to introduce a delay in execution of JS function that simulates an asynchronous operation.

image

@vercel
Copy link

vercel bot commented Oct 1, 2023

@Utsav2505 is attempting to deploy a commit to the SDC-USAR Team on Vercel.

A member of the Team first needs to authorize it.

@Utsav2505 Utsav2505 changed the title Update index.tsx fix #2: Added a Loader while image is generating. Oct 1, 2023
@shubhsardana29 shubhsardana29 requested a review from Adi-ty October 1, 2023 06:04
Adi-ty
Adi-ty requested changes Oct 1, 2023
View reviewed changes
Copy link
Member

@Adi-ty Adi-ty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want the loading animation to be visible on the output part below the prompt form.
Instead of simple generating text we can get a loading animation you can use radix-ui comp or maybe a simple spinner would also be ok, make use of Suspense boundary.

fenilmodi00
fenilmodi00 reviewed Oct 1, 2023
View reviewed changes
Copy link

@fenilmodi00 fenilmodi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's okiss

@Utsav2505 Utsav2505 closed this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenilmodi00 fenilmodi00 fenilmodi00 left review comments

@Adi-ty Adi-ty Adi-ty requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a loading animation while image is generating
3 participants
@Utsav2505 @fenilmodi00 @Adi-ty